Skip to content

Conversation

weihanglo
Copy link
Member

14 commits in 6cf8267012570f63d6b86e85a2ae5627de52df9e..307cbfda3119f06600e43cd38283f4a746fe1f8b
2025-03-14 15:25:36 +0000 to 2025-03-20 20:00:39 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Mar 22, 2025

📌 Commit 14062b2 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
@bors
Copy link
Collaborator

bors commented Mar 22, 2025

⌛ Testing commit 14062b2 with merge 2a1c8be...

@bors
Copy link
Collaborator

bors commented Mar 22, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 2a1c8be to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 22, 2025
@bors bors merged commit 2a1c8be into rust-lang:master Mar 22, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 22, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 48b36c9 (parent) -> 2a1c8be (this PR)

Test differences

Show 32938 test diffs
  • back::linker::tests::test_xlinker (stage 2): [missing] -> pass (J0)
  • doctest::tests::make_test_basic (stage 2): [missing] -> pass (J0)
  • error::verify_middle_layout_references_error_14 (stage 2): [missing] -> pass (J0)
  • errors::verify_ast_passes_extern_item_ascii_24 (stage 2): [missing] -> pass (J0)
  • errors::verify_ast_passes_fn_param_doc_comment_5 (stage 2): [missing] -> pass (J0)
  • errors::verify_ast_passes_static_without_body_13 (stage 2): [missing] -> pass (J0)
  • errors::verify_ast_passes_trait_fn_const_0 (stage 1): pass -> [missing] (J0)
  • errors::verify_builtin_macros_derive_path_args_value_47 (stage 1): pass -> [missing] (J0)
  • errors::verify_codegen_ssa_invalid_instruction_set_21 (stage 1): pass -> [missing] (J0)
  • errors::verify_codegen_ssa_unknown_reuse_kind_4 (stage 2): [missing] -> pass (J0)
  • errors::verify_expand_wrong_fragment_kind_26 (stage 1): pass -> [missing] (J0)
  • errors::verify_incremental_finalized_gc_failed_30 (stage 1): pass -> [missing] (J0)
  • errors::verify_parse_inclusive_range_no_end_34 (stage 2): [missing] -> pass (J0)
  • errors::verify_passes_ignored_attr_with_macro_6 (stage 2): [missing] -> pass (J0)
  • errors::verify_passes_transparent_incompatible_150 (stage 2): [missing] -> pass (J0)
  • errors::verify_privacy_from_private_dep_in_public_interface_4 (stage 1): pass -> [missing] (J0)
  • html::render::ordered_json::tests::string (stage 1): pass -> [missing] (J0)
  • layout::tree::tests::prune::should_accept::visible_def_in_seq_len_3 (stage 2): [missing] -> pass (J0)
  • lints::verify_lint_builtin_unsafe_block_7 (stage 2): [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_missing_note_4 (stage 2): [missing] -> pass (J0)
  • spec::tests::aarch64_apple_ios (stage 2): [missing] -> pass (J0)
  • spec::tests::aarch64_unknown_redox (stage 2): [missing] -> pass (J0)
  • spec::tests::arm_linux_androideabi (stage 1): pass -> [missing] (J0)
  • spec::tests::armv7r_none_eabi (stage 2): [missing] -> pass (J0)
  • spec::tests::riscv32imac_unknown_none_elf (stage 2): [missing] -> pass (J0)
  • spec::tests::riscv64gc_unknown_linux_musl (stage 1): pass -> [missing] (J0)
  • spec::tests::thumbv7m_nuttx_eabi (stage 1): pass -> [missing] (J0)
  • spec::tests::x86_64_unknown_hermit (stage 2): [missing] -> pass (J0)
  • symbols::tests::check_dup_symbol (stage 1): pass -> [missing] (J0)
  • tests::def_path_hash_depends_on_crate_id (stage 2): [missing] -> pass (J0)
  • tests::test_switch_implies_cfg_test_unless_cfg_test (stage 1): pass -> [missing] (J0)
  • tests::test_top_level_options_tracked_no_crate (stage 2): [missing] -> pass (J0)
  • alloc::const_unchecked_layout (stage 1): pass -> [missing] (J1)
  • collections::btree::map::tests::test_range (stage 2): [missing] -> pass (J1)
  • collections::btree::map::tests::test_values_mut (stage 1): pass -> [missing] (J1)
  • collections::btree::set::tests::test_from_iter (stage 1): pass -> [missing] (J1)
  • collections::linked_list::tests::test_iterator_double_end (stage 1): pass -> [missing] (J1)
  • condvar::wait_while (stage 1): pass -> [missing] (J1)
  • f64::test_to_radians (stage 1): pass -> [missing] (J1)
  • ffi::os_str::tests::slice_invalid_edge (stage 2): [missing] -> pass (J1)
  • fmt::builders::debug_list::test_multiple_non_exhaustive (stage 2): [missing] -> pass (J1)
  • fmt::builders::debug_tuple::test_empty_non_exhaustive (stage 2): [missing] -> pass (J1)
  • io::tests::test_take_wrong_length (stage 1): pass -> [missing] (J1)
  • iter::adapters::enumerate::test_iterator_enumerate_fold (stage 2): [missing] -> pass (J1)
  • iter::adapters::map_windows::drop_checks::no_iter_panic_n5 (stage 1): pass -> [missing] (J1)
  • iter::adapters::take::test_iterator_take_nth (stage 1): pass -> [missing] (J1)
  • net::parser::ipv6_corner_cases (stage 2): [missing] -> pass (J1)
  • nonzero::test_match_option_empty_string (stage 1): pass -> [missing] (J1)
  • num::i16::test_widening_mul (stage 2): [missing] -> pass (J1)
  • num::i32::test_be (stage 2): [missing] -> pass (J1)
  • num::i8::test_from_str_radix (stage 1): pass -> [missing] (J1)
  • num::i8::test_is_negative (stage 1): pass -> [missing] (J1)
  • num::test_boolu8 (stage 1): pass -> [missing] (J1)
  • num::test_try_i16u64 (stage 2): [missing] -> pass (J1)
  • num::u32::test_div_floor (stage 2): [missing] -> pass (J1)
  • option::as_slice (stage 2): [missing] -> pass (J1)
  • ptr::test_const_swap_ptr (stage 2): [missing] -> pass (J1)
  • rc::trait_object (stage 2): [missing] -> pass (J1)
  • rc::weak_self_cyclic (stage 2): [missing] -> pass (J1)
  • slice::slice_index::rangeinclusive_exhausted::pass (stage 2): [missing] -> pass (J1)
  • slice::test_align_to_empty_mid (stage 2): [missing] -> pass (J1)
  • slice::test_flatten_mut_size_overflow (stage 2): [missing] -> pass (J1)
  • slice::test_iterator_advance_by (stage 2): [missing] -> pass (J1)
  • sort::tests::stable::correct_u128_random_z1 (stage 2): [missing] -> pass (J1)
  • str::from_utf8_error (stage 2): [missing] -> pass (J1)
  • str::from_utf8_mostly_ascii (stage 2): [missing] -> pass (J1)
  • str::test_find_str (stage 2): [missing] -> pass (J1)
  • string::test_from_cow_str (stage 2): [missing] -> pass (J1)
  • string::test_replace_range_evil_end_bound (stage 2): [missing] -> pass (J1)
  • string::test_str_concat (stage 2): [missing] -> pass (J1)
  • sys_common::wtf8::tests::wtf8_display (stage 1): pass -> [missing] (J1)
  • test_prefix_ext (stage 2): [missing] -> pass (J1)
  • thin_box::align1small (stage 2): [missing] -> pass (J1)
  • thread::tests::test_avoid_copying_the_body_spawn (stage 2): [missing] -> pass (J1)
  • time::checked_div (stage 2): [missing] -> pass (J1)
  • vec::test_slice_out_of_bounds_4 (stage 2): [missing] -> pass (J1)
  • vec_deque::test_drop_with_pop (stage 1): pass -> [missing] (J1)
  • vec_deque::test_rotate_nop (stage 2): [missing] -> pass (J1)
  • ascii::medium::case08_fake_simd_u64 (stage 1): pass -> [missing] (J2)
  • iter::bench_filter_map_ref_sum (stage 1): pass -> [missing] (J2)
  • net::socket_addr::tests::ipv6_socket_addr_to_string (stage 2): [missing] -> pass (J2)
  • num::bench_u16_from_str_radix_2 (stage 1): pass -> [missing] (J2)
  • num::int_log::u16_log_random_small (stage 2): [missing] -> pass (J2)
  • num::midpoint::midpoint_order_expectation_u8 (stage 2): [missing] -> pass (J2)
  • slice::rotate_huge_by9199_big (stage 2): [missing] -> pass (J2)
  • sort::tests::stable::correct_i32_all_equal (stage 1): pass -> [missing] (J2)
  • sort::tests::stable::correct_i32_random_s50 (stage 2): [missing] -> pass (J2)
  • sort::tests::stable::panic_retain_orig_set_string_random (stage 2): [missing] -> pass (J2)
  • sort::tests::unstable::stability_string_random_s95 (stage 1): pass -> [missing] (J2)
  • str::char_count::zh_tiny::case00_libcore (stage 1): pass -> [missing] (J2)
  • str::rsplitn_space_char::long_lorem_ipsum (stage 1): pass -> [missing] (J2)
  • str::split_a_str::short_pile_of_poo (stage 1): pass -> [missing] (J2)
  • str::trim_start_ascii_char::short_mixed (stage 1): pass -> [missing] (J2)
  • tests::shuffle_tests_with_seed (stage 1): pass -> [missing] (J2)
  • vec::bench_rev_1 (stage 2): [missing] -> pass (J2)
  • sort::tests::stable::correct_f128_descending (stage 2): [missing] -> ignore (J3)
  • sort::tests::unstable::self_cmp_cell_i32_saw_mixed (stage 2): [missing] -> ignore (J3)
  • sort::tests::unstable::stability_cell_i32_random_d2 (stage 1): ignore -> [missing] (J3)
  • sys::pal::unix::kernel_copy::tests::dont_splice_pipes_from_files (stage 2): [missing] -> pass (J4)
  • f16::test_abs (stage 1): pass -> [missing] (J5)

(and 16364 additional test diffs)

Additionally, 16474 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-apple, x86_64-apple-1
  • J1: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
  • J2: aarch64-apple, test-various, x86_64-apple-1
  • J3: x86_64-gnu-aux
  • J4: test-various
  • J5: aarch64-apple

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2a1c8be): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
8.2% [8.2%, 8.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.6% [-1.6%, -1.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.3% [-1.6%, 8.2%] 2

Cycles

Results (secondary -9.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-9.2% [-9.3%, -9.0%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.347s -> 775.898s (0.07%)
Artifact size: 365.55 MiB -> 365.56 MiB (0.00%)

@weihanglo weihanglo deleted the update-cargo branch March 22, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants