Skip to content

Conversation

@zeroprooff
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@calebcartwright
Copy link
Member

Thank you but I'm going to close. tests often intentionally have seemingly odd things, and we also don't want to make these types of changes to subtree codebases within this repository to avoid churn and potential (git perceived) conflicts during synchronizations.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test test::verify_check_works ... ok
test test::configuration_snippet::configuration_snippet_tests ... ok

Mismatch at tests/source/issue-2523.rs:4:
 // Do not unindent macro calls in comment with unformattable syntax.
 //! ```rust
 //! let x = 3  ;
-//! some_macro!(pub fn fn foo() (
+//! some_macro!(pub fn foo() (
 //!     println!("Don't unindent me!");
 //! ));
 //! ```
{ "type": "test", "name": "test::self_tests", "event": "ok" }
test test::system_tests ... FAILED
test test::idempotence_tests ... ok

failures:

---- test::system_tests stdout ----
Warning: the `fn_args_layout` option is deprecated. Use `fn_params_layout`. instead
2025-04-17T17:29:39.862410Z  WARN rustfmt_nightly::test: Default value [] used explicitly for skip_macro_invocations
2025-04-17T17:29:39.898863Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for edition
2025-04-17T17:29:39.905268Z  WARN rustfmt_nightly::test: Default value Block used explicitly for imports_indent
2025-04-17T17:29:39.905274Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:39.954778Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:39.958444Z  WARN rustfmt_nightly::test: Default value true used explicitly for format_macro_bodies
2025-04-17T17:29:39.992647Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.074112Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
Warning: the `version` option is deprecated. Use `style_edition` instead.
Warning: the `version` option is deprecated. Use `style_edition` instead.
2025-04-17T17:29:40.220922Z  WARN rustfmt_nightly::test: Default value One used explicitly for version
2025-04-17T17:29:40.228272Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.294494Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.339573Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.393484Z  WARN rustfmt_nightly::test: Default value false used explicitly for wrap_comments
2025-04-17T17:29:40.444714Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_imports
2025-04-17T17:29:40.475980Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.525149Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_imports
2025-04-17T17:29:40.544260Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.546173Z  WARN rustfmt_nightly::test: Default value true used explicitly for merge_derives
2025-04-17T17:29:40.567017Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.572030Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.572034Z  WARN rustfmt_nightly::test: Default value 4 used explicitly for tab_spaces
2025-04-17T17:29:40.573902Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.575759Z  WARN rustfmt_nightly::test: Default value false used explicitly for use_field_init_shorthand
2025-04-17T17:29:40.579493Z  WARN rustfmt_nightly::test: Default value false used explicitly for condense_wildcard_suffixes
2025-04-17T17:29:40.584937Z  WARN rustfmt_nightly::test: Default value false used explicitly for reorder_impl_items
2025-04-17T17:29:40.590343Z  WARN rustfmt_nightly::test: Default value AlwaysSameLine used explicitly for control_brace_style
2025-04-17T17:29:40.595889Z  WARN rustfmt_nightly::test: Default value Block used explicitly for imports_indent
2025-04-17T17:29:40.595893Z  WARN rustfmt_nightly::test: Default value Mixed used explicitly for imports_layout
2025-04-17T17:29:40.597702Z  WARN rustfmt_nightly::test: Default value false used explicitly for hard_tabs
2025-04-17T17:29:40.602994Z  WARN rustfmt_nightly::test: Default value false used explicitly for fn_single_line
2025-04-17T17:29:40.608422Z  WARN rustfmt_nightly::test: Default value 10 used explicitly for short_array_element_width_threshold
2025-04-17T17:29:40.614050Z  WARN rustfmt_nightly::test: Default value 80 used explicitly for comment_width
2025-04-17T17:29:40.615822Z  WARN rustfmt_nightly::test: Default value false used explicitly for wrap_comments
2025-04-17T17:29:40.626984Z  WARN rustfmt_nightly::test: Default value true used explicitly for format_generated_files
2025-04-17T17:29:40.632229Z  WARN rustfmt_nightly::test: Default value true used explicitly for format_generated_files
2025-04-17T17:29:40.635826Z  WARN rustfmt_nightly::test: Default value true used explicitly for format_generated_files
2025-04-17T17:29:40.639359Z  WARN rustfmt_nightly::test: Default value true used explicitly for force_explicit_abi
2025-04-17T17:29:40.643841Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.648328Z  WARN rustfmt_nightly::test: Default value Vertical used explicitly for trailing_comma
2025-04-17T17:29:40.651970Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.651974Z  WARN rustfmt_nightly::test: Default value false used explicitly for format_strings
2025-04-17T17:29:40.658360Z  WARN rustfmt_nightly::test: Default value 50 used explicitly for single_line_let_else_max_width
2025-04-17T17:29:40.663048Z  WARN rustfmt_nightly::test: Default value false used explicitly for normalize_comments
2025-04-17T17:29:40.666668Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.668552Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.670488Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.674165Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.677851Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.677854Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.679691Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.679699Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.679701Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.681487Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.685133Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.686965Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.695996Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.701487Z  WARN rustfmt_nightly::test: Default value Block used explicitly for indent_style
2025-04-17T17:29:40.719812Z  WARN rustfmt_nightly::test: Default value false used explicitly for match_block_trailing_comma
2025-04-17T17:29:40.727130Z  WARN rustfmt_nightly::test: Default value SameLineWhere used explicitly for brace_style
2025-04-17T17:29:40.732587Z  WARN rustfmt_nightly::test: Default value SameLineWhere used explicitly for brace_style
2025-04-17T17:29:40.734440Z  WARN rustfmt_nightly::test: Default value Default used explicitly for use_small_heuristics
2025-04-17T17:29:40.740399Z  WARN rustfmt_nightly::test: Default value false used explicitly for wrap_comments
2025-04-17T17:29:40.740404Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.746008Z  WARN rustfmt_nightly::test: Default value true used explicitly for format_macro_bodies
2025-04-17T17:29:40.754541Z  WARN rustfmt_nightly::test: Default value Tall used explicitly for fn_params_layout
2025-04-17T17:29:40.756433Z  WARN rustfmt_nightly::test: Default value true used explicitly for merge_derives
2025-04-17T17:29:40.758388Z  WARN rustfmt_nightly::test: Default value false used explicitly for force_multiline_blocks
2025-04-17T17:29:40.764287Z  WARN rustfmt_nightly::test: Default value false used explicitly for normalize_doc_attributes
2025-04-17T17:29:40.769683Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_imports
2025-04-17T17:29:40.771481Z  WARN rustfmt_nightly::test: Default value false used explicitly for format_macro_matchers
2025-04-17T17:29:40.786101Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_modules
2025-04-17T17:29:40.791250Z  WARN rustfmt_nightly::test: Default value false used explicitly for disable_all_formatting
2025-04-17T17:29:40.794656Z  WARN rustfmt_nightly::test: Default value Wide used explicitly for type_punctuation_density
2025-04-17T17:29:40.800311Z  WARN rustfmt_nightly::test: Default value true used explicitly for empty_item_single_line
2025-04-17T17:29:40.802105Z  WARN rustfmt_nightly::test: Default value false used explicitly for use_try_shorthand
2025-04-17T17:29:40.805803Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.809418Z  WARN rustfmt_nightly::test: Default value true used explicitly for match_arm_blocks
2025-04-17T17:29:40.813029Z  WARN rustfmt_nightly::test: Default value false used explicitly for spaces_around_ranges
2025-04-17T17:29:40.816994Z  WARN rustfmt_nightly::test: Default value Never used explicitly for match_arm_leading_pipes
2025-04-17T17:29:40.822831Z  WARN rustfmt_nightly::test: Default value 100 used explicitly for doc_comment_code_block_width
2025-04-17T17:29:40.826955Z  WARN rustfmt_nightly::test: Default value 100 used explicitly for doc_comment_code_block_width
2025-04-17T17:29:40.828991Z  WARN rustfmt_nightly::test: Default value true used explicitly for remove_nested_parens
2025-04-17T17:29:40.890535Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.893464Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:40.893468Z  WARN rustfmt_nightly::test: Default value false used explicitly for error_on_line_overflow
2025-04-17T17:29:40.896187Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
Warning: the `version` option is deprecated. Use `style_edition` instead.
2025-04-17T17:29:40.904866Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
Warning: the `merge_imports` option is deprecated. Use `imports_granularity="Crate"` instead
2025-04-17T17:29:40.954938Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_modules
2025-04-17T17:29:40.986614Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:41.054199Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:41.135671Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
2025-04-17T17:29:41.144087Z  WARN rustfmt_nightly::test: Default value true used explicitly for reorder_imports
2025-04-17T17:29:41.154434Z  WARN rustfmt_nightly::test: Default value 2015 used explicitly for style_edition
Ran 615 system tests.

thread '<unnamed>' panicked at src/tools/rustfmt/src/test/mod.rs:189:9:
assertion `left == right` failed: 1 system tests failed
  left: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants