Skip to content

Implement ptr::is_aligned_for and NonNull::is_aligned_for. #140982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Implement ptr::is_aligned_for and NonNull::is_aligned_for. #140982

wants to merge 3 commits into from

Conversation

@mathisbot
Copy link
Contributor

@mathisbot mathisbot commented May 13, 2025 •
edited
Loading

Implement three related methods on pointers: is_aligned_for.

Warning

The ACP has not yet been accepted.

@rustbot
Copy link
Collaborator

rustbot commented May 13, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 13, 2025
This was referenced May 13, 2025
Closed
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
zachs18
zachs18 reviewed May 14, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented May 19, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit 349059c has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
@mathisbot
Copy link
Contributor Author

mathisbot commented May 19, 2025 •
edited
Loading

@thomcc I may have made the mistake of not linking the ACP to this implementation, but it hasn't been accepted yet. My bad.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2025
@mathisbot mathisbot force-pushed the core_ptr_is_aligned_for branch from 346ae3d to e51e908 Compare May 19, 2025 22:31
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels May 19, 2025
@mathisbot
Copy link
Contributor Author

mathisbot commented May 20, 2025

Closed in favor of #141221

@mathisbot mathisbot closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zachs18 zachs18 zachs18 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thomcc thomcc

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mathisbot @rustbot @rust-log-analyzer @thomcc @bors @zachs18