Skip to content

Conversation

chenyukang
Copy link
Member

Fixes #140333

@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@compiler-errors
Copy link
Member

compiler-errors commented Jun 12, 2025

Sorry for the delay on the review. I don't believe this is the right fix. Namely, I think the root cause is a bit involved -- see #142393.

@chenyukang
Copy link
Member Author

Sorry for the delay on the review. I don't believe this is the right fix. Namely, I think the root cause is a bit involved -- see #142393.

I have read your code, it is more complicated than I thought, thank you. I'm closing this PR now.

@chenyukang chenyukang closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: None in pretty printing self.print_ident(field.ident.unwrap());
3 participants