Skip to content

Conversation

weihanglo
Copy link
Member

9 commits in 47c911e9e6f6461f90ce19142031fe16876a3b95..68db37499f2de8acef704c73d9031be6fbcbaee4
2025-05-14 17:53:17 +0000 to 2025-05-22 14:27:15 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented May 23, 2025

📌 Commit 11a6348 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
@bors
Copy link
Collaborator

bors commented May 23, 2025

⌛ Testing commit 11a6348 with merge 80c3498...

@bors
Copy link
Collaborator

bors commented May 24, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 80c3498 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 24, 2025
@bors bors merged commit 80c3498 into rust-lang:master May 24, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 24, 2025
@weihanglo weihanglo deleted the update-cargo branch May 24, 2025 00:58
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3e674b0 (parent) -> 80c3498 (this PR)

Test differences

Show 33335 test diffs

Stage 1

  • collections::btree::map::tests::test_bad_zst: pass -> [missing] (J0)
  • collections::btree::map::tests::test_extract_if::underfull_keeping_one: pass -> [missing] (J0)
  • collections::btree::set::tests::test_iter_min_max: pass -> [missing] (J0)
  • floats::f32::test_one: pass -> [missing] (J0)
  • mpsc::shared_chan_stress: pass -> [missing] (J0)
  • mpsc_sync::smoke_chan_gone_shared: pass -> [missing] (J0)
  • num::dec2flt::decimal::check_fast_path_f32: pass -> [missing] (J0)
  • num::i16::test_abs: pass -> [missing] (J0)
  • num::int_sqrt::i16::isqrt: pass -> [missing] (J0)
  • num::ops::test_bitxor_assign_defined: pass -> [missing] (J0)
  • num::test_i8i16: pass -> [missing] (J0)
  • num::test_int_from_str_overflow: pass -> [missing] (J0)
  • num::u64::test_unbounded_shl: pass -> [missing] (J0)
  • ptr::align_offset_zst: pass -> [missing] (J0)
  • slice::test_remove: pass -> [missing] (J0)
  • sort::tests::stable::fixed_seed: pass -> [missing] (J0)
  • sort::tests::stable::self_cmp_string_random_z1: pass -> [missing] (J0)
  • sort::tests::unstable::deterministic_string_random_z1: pass -> [missing] (J0)
  • str::test_str_from_utf8: pass -> [missing] (J0)
  • string::test_extend_ref: pass -> [missing] (J0)
  • vec::test_into_iter_drop_allocator: pass -> [missing] (J0)
  • vec::test_vec_truncate_fail: pass -> [missing] (J0)
  • errors::verify_ast_passes_auto_generic_29: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_extract_bundled_libs_parse_archive_70: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_incorrect_cgu_reuse_type_1: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_invalid_monomorphization_cannot_return_115: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_select_cpp_build_tool_workload_47: pass -> [missing] (J1)
  • errors::verify_metadata_crate_not_panic_runtime_42: pass -> [missing] (J1)
  • errors::verify_metadata_fail_create_file_encoder_40: pass -> [missing] (J1)
  • errors::verify_metadata_whole_archive_needs_static_26: pass -> [missing] (J1)
  • errors::verify_parse_single_colon_import_path_150: pass -> [missing] (J1)
  • errors::verify_session_profile_sample_use_file_does_not_exist_5: pass -> [missing] (J1)
  • parser::tests::attrs_fix_bug: pass -> [missing] (J1)
  • tests::list_test_macros: pass -> [missing] (J1)
  • tests::test_fn_like_macro_clone_ident_subtree: pass -> [missing] (J1)
  • btree::map::first_and_last_100_nightly: pass -> [missing] (J2)
  • fmt::write_vec_macro1: pass -> [missing] (J2)
  • iter::bench_enumerate_sum: pass -> [missing] (J2)
  • num::int_sqrt::i16::isqrt_extended: pass -> [missing] (J2)
  • process::tests::test_command_implements_send_sync: pass -> [missing] (J2)
  • sort::tests::stable::correct_1k_random_s95: pass -> [missing] (J2)
  • sort::tests::stable::observable_is_less_saw_mixed: pass -> [missing] (J2)
  • sort::tests::unstable::violate_ord_retain_orig_set_i32_random: pass -> [missing] (J2)
  • str::contains_bang_str::long_lorem_ipsum: pass -> [missing] (J2)
  • str::starts_with_str::short_ascii: pass -> [missing] (J2)
  • tests::do_not_run_ignored_tests: pass -> [missing] (J2)
  • vec::bench_in_place_xu32_0100_i0: pass -> [missing] (J2)
  • sort::tests::stable::correct_string_ascending: ignore -> [missing] (J4)
  • thread::tests::scope_join_race: pass -> [missing] (J4)

Stage 2

  • barrier::test_barrier: [missing] -> pass (J0)
  • collections::binary_heap::test_push: [missing] -> pass (J0)
  • collections::btree::map::tests::test_extract_if::height_2_removing_all: [missing] -> pass (J0)
  • collections::btree::set::tests::test_union_size_hint: [missing] -> pass (J0)
  • collections::vec_deque::tests::test_vec_from_vecdeque: [missing] -> pass (J0)
  • fmt::builders::debug_tuple::test_multiple_and_non_exhaustive: [missing] -> pass (J0)
  • io::borrowed_buf::initialize_unfilled: [missing] -> pass (J0)
  • io::error::tests::test_debug_error: [missing] -> pass (J0)
  • iter::range::test_double_ended_range: [missing] -> pass (J0)
  • mpmc::issue_32114: [missing] -> pass (J0)
  • num::i16::test_checked_next_multiple_of: [missing] -> pass (J0)
  • num::test_i8f32: [missing] -> pass (J0)
  • num::test_try_i8i128: [missing] -> pass (J0)
  • num::test_try_u128i128: [missing] -> pass (J0)
  • num::test_try_u32i128: [missing] -> pass (J0)
  • num::test_u16f32: [missing] -> pass (J0)
  • num::u128::test_carrying_add: [missing] -> pass (J0)
  • option::test_option_too_much_dance: [missing] -> pass (J0)
  • pattern::test_stress_indices: [missing] -> pass (J0)
  • str::slice_index::rangetoinclusive_len::index_mut_fail: [missing] -> pass (J0)
  • str::test_escape_debug: [missing] -> pass (J0)
  • string::test_from_cow_str: [missing] -> pass (J0)
  • test_add_extension: [missing] -> pass (J0)
  • test_extension_path_sep_alternate: [missing] -> pass (J0)
  • bit_set::tests::bench_insert: [missing] -> pass (J1)
  • errors::verify_ast_lowering_no_precise_captures_on_apit_34: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_66: [missing] -> pass (J1)
  • errors::verify_const_eval_non_const_await_31: [missing] -> pass (J1)
  • errors::verify_incremental_write_new_20: [missing] -> pass (J1)
  • errors::verify_mir_dataflow_duplicate_values_for_2: [missing] -> pass (J1)
  • errors::verify_parse_unexpected_token_after_struct_name_found_reserved_identifier_89: [missing] -> pass (J1)
  • errors::verify_passes_incorrect_do_not_recommend_args_2: [missing] -> pass (J1)
  • lints::verify_lint_builtin_missing_copy_impl_24: [missing] -> pass (J1)
  • lints::verify_lint_span_use_eq_ctxt_56: [missing] -> pass (J1)
  • obligation_forest::tests::diamond: [missing] -> pass (J1)
  • spec::tests::aarch64_unknown_trusty: [missing] -> pass (J1)
  • spec::tests::i686_win7_windows_msvc: [missing] -> pass (J1)
  • spec::tests::mips_unknown_linux_musl: [missing] -> pass (J1)
  • spec::tests::riscv64_linux_android: [missing] -> pass (J1)
  • vec::tests::index_size_is_optimized: [missing] -> pass (J1)
  • ascii::short::is_ascii_whitespace: [missing] -> pass (J2)
  • btree::map::iter_1: [missing] -> pass (J2)
  • btree::set::intersection_staggered_100_vs_10k: [missing] -> pass (J2)
  • hash::sip::bench_u64: [missing] -> pass (J2)
  • iter::bench_lt: [missing] -> pass (J2)
  • sort::tests::stable::deterministic_i32_random_d20: [missing] -> pass (J2)
  • sort::tests::stable::stability_cell_i32_descending: [missing] -> pass (J2)
  • str::contains_bang_char::short_pile_of_poo: [missing] -> pass (J2)
  • fs::tests::test_read_dir_infinite_loop: [missing] -> pass (J3)
  • sort::tests::stable::observable_is_less_random: [missing] -> ignore (J4)
  • sort::tests::unstable::panic_retain_orig_set_i32_random_d2: [missing] -> ignore (J4)

(and 16629 additional test diffs)

Additionally, 16606 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 80c34983c63968c204096e79b9126c0039790741 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 6193.6s -> 1435.2s (-76.8%)
  2. test-various: 4276.7s -> 2312.9s (-45.9%)
  3. x86_64-apple-1: 8790.9s -> 5743.2s (-34.7%)
  4. x86_64-gnu-aux: 6297.8s -> 4467.3s (-29.1%)
  5. dist-x86_64-apple: 9011.9s -> 7707.3s (-14.5%)
  6. aarch64-apple: 4363.7s -> 3926.6s (-10.0%)
  7. dist-apple-various: 6319.0s -> 6695.7s (6.0%)
  8. dist-s390x-linux: 5149.3s -> 5432.4s (5.5%)
  9. dist-riscv64-linux: 5362.8s -> 5078.1s (-5.3%)
  10. dist-loongarch64-musl: 5561.3s -> 5282.0s (-5.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (80c3498): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.257s -> 778.415s (-0.11%)
Artifact size: 365.50 MiB -> 366.33 MiB (0.23%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants