compiler: reuse a constructed-once AbiMap #142763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
abimap-conveniences
branch
from
9e3a093 to
f126ca9
Compare
Member
Author
|
Wait, of course. I'd have to set it on targets... ugh. |
workingjubilee
force-pushed
the
abimap-conveniences
branch
from
f126ca9 to
867d001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor convenience for code in the compiler that needs to get a CanonAbi. It makes it harder to construct an AbiMap, but also easier to get one without needing to import AbiMap and directly use its constructor. We preserve the public constructor for this PR, though, due to potential conflicts with other PRs.
cc @folkertdev