Skip to content

Conversation

@tshepang
Copy link
Member

Posting now to check if the direction is good before doing the blessing

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
fmt: checked 6114 files
tidy check
/checkout/tests/assembly/asm/riscv-types.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv32 should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv32-zfh should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv32-zfhmin should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv64 should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv64-zfh should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/assembly/asm/riscv-types.rs: revision riscv64-zfhmin should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/riscv32e-registers.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/ui/asm/riscv/riscv32e-registers.rs: revision riscv32e should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/riscv32e-registers.rs: revision riscv32em should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/riscv32e-registers.rs: revision riscv32emc should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv32e should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv32gc should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv32i should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv32imafc should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv64gc should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/asm/riscv/bad-reg.rs: revision riscv64imac should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/abi/riscv-discoverability-guidance.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/ui/abi/riscv-discoverability-guidance.rs: revision riscv32 should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/ui/abi/riscv-discoverability-guidance.rs: revision riscv64 should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/asm/riscv-clobbers.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/codegen/asm/riscv-clobbers.rs: revision rv32e should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/asm/riscv-clobbers.rs: revision rv32i should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/asm/riscv-clobbers.rs: revision rv64i should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/riscv-target-abi.rs: revision [unspecified] should not specify `needs-llvm-components:` as it doesn't need `--target`
/checkout/tests/codegen/riscv-target-abi.rs: revision riscv32gc should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/riscv-target-abi.rs: revision riscv32imac should specify `needs-llvm-components:` as it has `--target` set
/checkout/tests/codegen/riscv-target-abi.rs: revision riscv64gc should specify `needs-llvm-components:` as it has `--target` set
Checking tidy rustdoc_json...
Running eslint on rustdoc JS files
`rustdoc-json-types` was not modified.
tidy: Skipping binary file check, read-only filesystem
removing old virtual environment
---
All checks passed!
checking python file formatting
28 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:13
  local time: Sat Jun 21 15:56:51 UTC 2025
  network time: Sat, 21 Jun 2025 15:56:51 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@tshepang
Copy link
Member Author

oh, interesting that tidy checks for this (and that it does not like the direction)

@tshepang tshepang closed this Jun 21, 2025
@tshepang tshepang deleted the repetition branch June 21, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants