-
Notifications
You must be signed in to change notification settings - Fork 14.1k
[perf] Try to skip some early lints with --cap-lints
#142912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] Try to skip some early lints with `--cap-lints` Opening for perf. r? `@ghost`
|
@bors2 try |
[perf] Try to skip some early lints with `--cap-lints` Opening for perf. r? `@ghost`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (702ebc3): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.4%, secondary 1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 6.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 688.878s -> 688.462s (-0.06%) |
|
Hmm, I didn't expect any perf. wins on rustbot, because it doesn't measure dependencies, but I don't see any wins even locally :/ |
|
@bors2 try |
[perf] Try to skip some early lints with `--cap-lints` Opening for perf. r? `@ghost`
|
No, still nothing. I wonder if these 4 excluded lints are the most expensive ones 🤔 |
|
My recollection from a couple years ago when I looked at this is that linting dependencies in our benchmarks were <100ms or so. Do you see something different now? |
|
I benchmarked this a few months ago, late lints were super fast, but the early ones seemed to be a bit more expensive. I don't remember the details though, I'll need to re-check. I also benchmarked it locally, not with PGO, which is always a bit misleading. |
|
Hmm, it seems like the early lints are "quick" now. Maybe I benchmarked it wrongly before. |
Opening for perf.
r? @ghost