Skip to content

Conversation

weihanglo
Copy link
Member

14 commits in 930b4f62cfcd1f0eabdb30a56d91bf6844b739bf..eabb4cd923deb73e714f7ad3f5234d68ca284dbe
2025-06-28 14:58:43 +0000 to 2025-07-09 22:07:55 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2025
@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit 2268e06 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
@matthiaskrgr
Copy link
Member

@bors p=5 threading between rollups

@bors
Copy link
Collaborator

bors commented Jul 12, 2025

⌛ Testing commit 2268e06 with merge 9535fee...

@bors
Copy link
Collaborator

bors commented Jul 12, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 9535fee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 12, 2025
@bors bors merged commit 9535fee into rust-lang:master Jul 12, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 12, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 855e0fe (parent) -> 9535fee (this PR)

Test differences

Show 54 test diffs

Stage 2

  • bad_config::bad_bench_name: [missing] -> pass (J0)
  • bad_config::bad_bin_name: [missing] -> pass (J0)
  • bad_config::bad_example_name: [missing] -> pass (J0)
  • bad_config::bad_test_name: [missing] -> pass (J0)
  • bad_config::commonly_wrong_path_binary: [missing] -> pass (J0)
  • bad_config::commonly_wrong_path_of_benchmark: [missing] -> pass (J0)
  • bad_config::commonly_wrong_path_of_example: [missing] -> pass (J0)
  • bad_config::commonly_wrong_path_of_test: [missing] -> pass (J0)
  • bad_config::commonly_wrong_path_subdir_binary: [missing] -> pass (J0)
  • bad_config::found_multiple_target_files: [missing] -> pass (J0)
  • bad_config::legacy_binary_paths_warnings: [missing] -> pass (J0)
  • bad_config::non_existing_benchmark: [missing] -> pass (J0)
  • bad_config::non_existing_binary: [missing] -> pass (J0)
  • bad_config::non_existing_example: [missing] -> pass (J0)
  • bad_config::non_existing_test: [missing] -> pass (J0)
  • build::commonly_wrong_path_binary: pass -> [missing] (J0)
  • build::commonly_wrong_path_of_benchmark: pass -> [missing] (J0)
  • build::commonly_wrong_path_of_example: pass -> [missing] (J0)
  • build::commonly_wrong_path_of_test: pass -> [missing] (J0)
  • build::commonly_wrong_path_subdir_binary: pass -> [missing] (J0)
  • build::found_multiple_target_files: pass -> [missing] (J0)
  • build::legacy_binary_paths_warnings: pass -> [missing] (J0)
  • build::non_existing_benchmark: pass -> [missing] (J0)
  • build::non_existing_binary: pass -> [missing] (J0)
  • build::non_existing_example: pass -> [missing] (J0)
  • build::non_existing_test: pass -> [missing] (J0)
  • build_scripts_multiple::build_script_with_conflicting_environment_variables: [missing] -> pass (J0)
  • build_scripts_multiple::build_script_with_conflicting_out_dirs: [missing] -> pass (J0)
  • build_scripts_multiple::custom_build_script_first_index_script_failed: [missing] -> pass (J0)
  • build_scripts_multiple::custom_build_script_second_index_script_failed: [missing] -> pass (J0)
  • feature_unification::cargo_fix_works: [missing] -> pass (J0)
  • feature_unification::edition_v2_resolver_report: [missing] -> pass (J0)
  • feature_unification::feature_unification_cargo_tree: [missing] -> pass (J0)
  • feature_unification::feature_unification_of_cli_features_within_workspace: [missing] -> pass (J0)
  • feature_unification::package_feature_unification: [missing] -> pass (J0)
  • feature_unification::package_feature_unification_cli_features: [missing] -> pass (J0)
  • feature_unification::package_feature_unification_default_features: [missing] -> pass (J0)
  • feature_unification::package_feature_unification_weak_dependencies: [missing] -> pass (J0)
  • package::checksum_changed: [missing] -> pass (J0)
  • package::registry_not_inferred_because_of_conflict_nightly: pass -> [missing] (J0)
  • package::registry_not_inferred_because_of_mismatch_nightly: pass -> [missing] (J0)
  • package::registry_not_inferred_because_of_multiple_options_nightly: pass -> [missing] (J0)
  • package::unpublished_cyclic_dev_dependencies_nightly: pass -> [missing] (J0)
  • package::workspace_with_local_dep_already_published_nightly: pass -> [missing] (J0)
  • package::workspace_with_local_deps_nightly: pass -> [missing] (J0)
  • package::workspace_with_local_deps_packaging_one_fails_nightly: pass -> [missing] (J0)
  • publish::checksum_changed: [missing] -> pass (J0)
  • publish::package_selection_nightly: pass -> [missing] (J0)
  • publish::workspace_with_local_deps_nightly: pass -> [missing] (J0)

Additionally, 5 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9535feebd5741a55fc24e84060e82d41a75dac6e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 5118.5s -> 6626.9s (29.5%)
  2. dist-x86_64-apple: 7593.2s -> 8545.3s (12.5%)
  3. aarch64-apple: 4373.7s -> 4902.3s (12.1%)
  4. dist-ohos-x86_64: 4234.9s -> 3898.5s (-7.9%)
  5. x86_64-apple-2: 5055.8s -> 5451.5s (7.8%)
  6. dist-x86_64-solaris: 4979.5s -> 5361.0s (7.7%)
  7. dist-x86_64-msvc: 6360.6s -> 5948.0s (-6.5%)
  8. x86_64-apple-1: 7454.3s -> 7912.5s (6.1%)
  9. pr-check-1: 1856.3s -> 1743.5s (-6.1%)
  10. x86_64-gnu-llvm-19-2: 6414.6s -> 6029.2s (-6.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@weihanglo weihanglo deleted the update-cargo branch July 12, 2025 08:28
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9535fee): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [3.0%, 4.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.604s -> 463.248s (-0.29%)
Artifact size: 374.58 MiB -> 374.72 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants