Skip to content

Dont collect assoc ty item bounds from trait where clause for host effect predicates #143895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Jul 17, 2025
Merged

Dont collect assoc ty item bounds from trait where clause for host effect predicates #143895

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef726a4
Ensure proper item queries for assoc tys
compiler-errors Jul 13, 2025
549a5d8
Dont collect assoc ty item bounds from trait where clause for host ef…
compiler-errors Jul 13, 2025
8daf98b
Imply always-const host effects the same as any other item bound
compiler-errors Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/rustc_hir_analysis/src/collect/item_bounds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ fn remap_gat_vars_and_recurse_into_nested_projections<'tcx>(
ty::ClauseKind::Trait(tr) => tr.self_ty(),
ty::ClauseKind::Projection(proj) => proj.projection_term.self_ty(),
ty::ClauseKind::TypeOutlives(outlives) => outlives.0,
ty::ClauseKind::HostEffect(host) => host.self_ty(),
_ => return None,
Copy link
Contributor

@oli-obk oli-obk Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good candidate for an exhaustive match

};

Expand Down
19 changes: 19 additions & 0 deletions tests/ui/traits/const-traits/imply-always-const.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//@ check-pass

#![feature(const_trait_impl)]

#[const_trait]
trait A where Self::Assoc: const B {
type Assoc;
}

#[const_trait]
trait B {}

fn needs_b<T: const B>() {}

fn test<T: A>() {
needs_b::<T::Assoc>();
}

fn main() {}
Loading