Stabilize `new_zeroed_alloc` #144091

thaliaarchi · 2025-07-17T22:38:33Z

The corresponding new_uninit and new_uninit_slice functions were stabilized in #129401, but the zeroed counterparts were left for later out of a desire to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them.

Tracking issue: #129396

rustbot · 2025-07-17T22:38:37Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

thaliaarchi · 2025-07-17T23:09:06Z

@jieyouxu Are the bootstrap gates for rustc_index correct with the redesigned bootstrap sequence? It needs to be compilable in four ways: with feature = "nightly" by stage0, stage1, or from crates.io, or without feature = "nightly" from crates.io.

compiler/rustc_index/src/lib.rs

library/alloc/src/boxed.rs

Amanieu · 2025-07-22T16:43:50Z

@rfcbot merge

rfcbot · 2025-07-22T16:43:52Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Mark-Simulacrum · 2025-09-20T22:08:10Z

compiler/rustc_index/src/bit_set.rs

                    #[cfg(not(feature = "nightly"))]
                    let mut words = {
-                        // FIXME: unconditionally use `Rc::new_zeroed` once it is stable (#63291).
+                        // FIXME: unconditionally use `Rc::new_zeroed` once it is stable (#129396).


IIUC, this probably wants to replace the feature = nightly / not nightly with cfg on bootstrap, right? That the dead code will get automatically removed in the next bump.

We can probably do this in follow up though since there's not anything else missing from this PR and it's just a cleanup.

I left that, to give some time for any crates relying on rustc_index to bump their MSRV. But I don't know our policy on that kind of thing.

Ah, I guess that's true, that should probably wait until this makes it to stable. I don't think we should support more than a single (latest) stable release though.

library/alloc/src/boxed.rs

Mark-Simulacrum · 2025-09-20T22:10:52Z

@bors r+

bors · 2025-09-20T22:10:55Z

📌 Commit 175afd7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…lacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: #129396

bors · 2025-09-20T23:05:45Z

⌛ Testing commit 175afd7 with merge e9c050c...

…r=Mark-Simulacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: rust-lang#129396

tgross35 · 2025-09-20T23:09:09Z

@bors retry rolled up

Rollup of 6 pull requests Successful merges: - #140983 (Improve doc of some methods that take ranges) - #144091 (Stabilize `new_zeroed_alloc`) - #145664 (Stabilize `std::panic::Location::file_as_c_str`) - #146744 (Deref related cleanups in ref_prop) - #146793 (naked_asm: emit a label starting with `func_end`) - #146822 (Fix old typo in lang_start_internal comment) r? `@ghost` `@rustbot` modify labels: rollup

…lacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: #129396

bors · 2025-09-21T00:26:37Z

⌛ Testing commit 175afd7 with merge 95cd055...

tgross35 · 2025-09-21T00:35:27Z

@bors retry same thing

Rollup of 6 pull requests Successful merges: - #140983 (Improve doc of some methods that take ranges) - #144091 (Stabilize `new_zeroed_alloc`) - #145664 (Stabilize `std::panic::Location::file_as_c_str`) - #146744 (Deref related cleanups in ref_prop) - #146793 (naked_asm: emit a label starting with `func_end`) - #146822 (Fix old typo in lang_start_internal comment) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-21T04:21:11Z

⌛ Testing commit 175afd7 with merge 8380f92...

…lacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: #129396

Zalathar · 2025-09-21T04:44:02Z

Yielding to rollup again. Sorry for the noise; CI has been flaking out.

@bors retry

Rollup of 8 pull requests Successful merges: - #140983 (Improve doc of some methods that take ranges) - #144091 (Stabilize `new_zeroed_alloc`) - #145664 (Stabilize `std::panic::Location::file_as_c_str`) - #146551 (fix issue with `cmse-nonsecure-entry` ABI being both async and c-variadic) - #146744 (Deref related cleanups in ref_prop) - #146793 (naked_asm: emit a label starting with `func_end`) - #146820 (Add unstable attribute to BTreeMap-related allocator generics) - #146822 (Fix old typo in lang_start_internal comment) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-21T07:51:49Z

⌛ Testing commit 175afd7 with merge dfa2223...

Rollup merge of #144091 - thaliaarchi:stabilize-new-zeroed, r=Mark-Simulacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in #129401, but the zeroed counterparts were left for later out of a [desire](#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: #129396

…r=Mark-Simulacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: rust-lang#129396

Rollup of 8 pull requests Successful merges: - rust-lang#140983 (Improve doc of some methods that take ranges) - rust-lang#144091 (Stabilize `new_zeroed_alloc`) - rust-lang#145664 (Stabilize `std::panic::Location::file_as_c_str`) - rust-lang#146551 (fix issue with `cmse-nonsecure-entry` ABI being both async and c-variadic) - rust-lang#146744 (Deref related cleanups in ref_prop) - rust-lang#146793 (naked_asm: emit a label starting with `func_end`) - rust-lang#146820 (Add unstable attribute to BTreeMap-related allocator generics) - rust-lang#146822 (Fix old typo in lang_start_internal comment) r? `@ghost` `@rustbot` modify labels: rollup

…r=Mark-Simulacrum Stabilize `new_zeroed_alloc` The corresponding `new_uninit` and `new_uninit_slice` functions were stabilized in rust-lang#129401, but the zeroed counterparts were left for later out of a [desire](rust-lang#63291 (comment)) to stabilize only the minimal set. These functions are straightforward mirrors of the uninit functions and well-established. Since no blockers or design questions have surfaced in the past year, I think it's time to stabilize them. Tracking issue: rust-lang#129396

rustbot assigned Mark-Simulacrum Jul 17, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 17, 2025

thaliaarchi mentioned this pull request Jul 17, 2025

Tracking Issue for new_zeroed_alloc #129396

Open

2 tasks

This comment has been minimized.

Sign in to view

thaliaarchi force-pushed the stabilize-new-zeroed branch 2 times, most recently from 36a935b to a84ecd9 Compare July 17, 2025 23:07

This comment has been minimized.

Sign in to view

thaliaarchi force-pushed the stabilize-new-zeroed branch 2 times, most recently from f9df154 to 081ce42 Compare July 17, 2025 23:37

Mark-Simulacrum requested changes Jul 19, 2025

View reviewed changes

compiler/rustc_index/src/lib.rs Outdated Show resolved Hide resolved

library/alloc/src/boxed.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025

thaliaarchi force-pushed the stabilize-new-zeroed branch from 081ce42 to 0c18553 Compare July 19, 2025 23:30

This comment has been minimized.

Sign in to view

thaliaarchi force-pushed the stabilize-new-zeroed branch from 0c18553 to 6d1c12a Compare July 19, 2025 23:37

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

thaliaarchi force-pushed the stabilize-new-zeroed branch from 6d1c12a to c82db9b Compare July 19, 2025 23:53

Stabilize new_zeroed_alloc

175afd7

thaliaarchi force-pushed the stabilize-new-zeroed branch from c82db9b to 175afd7 Compare July 20, 2025 03:25

Mark-Simulacrum approved these changes Sep 20, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2025

tgross35 mentioned this pull request Sep 20, 2025

Rollup of 9 pull requests #146824

Closed

tgross35 mentioned this pull request Sep 20, 2025

Rollup of 6 pull requests #146825

Closed

Zalathar mentioned this pull request Sep 21, 2025

Rollup of 8 pull requests #146830

Merged

bors merged commit 7a5819d into rust-lang:master Sep 21, 2025
11 of 12 checks passed

rustbot added this to the 1.92.0 milestone Sep 21, 2025

thaliaarchi deleted the stabilize-new-zeroed branch September 21, 2025 21:48

Stabilize new_zeroed_alloc #144091

Stabilize new_zeroed_alloc #144091

Uh oh!

Conversation

thaliaarchi commented Jul 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 17, 2025

Uh oh!

This comment has been minimized.

thaliaarchi commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

Amanieu commented Jul 22, 2025

Uh oh!

rfcbot commented Jul 22, 2025 • edited by joshtriplett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

thaliaarchi Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mark-Simulacrum commented Sep 20, 2025

Uh oh!

bors commented Sep 20, 2025

Uh oh!

bors commented Sep 20, 2025

Uh oh!

tgross35 commented Sep 20, 2025

Uh oh!

bors commented Sep 21, 2025

Uh oh!

tgross35 commented Sep 21, 2025

Uh oh!

bors commented Sep 21, 2025

Uh oh!

Zalathar commented Sep 21, 2025

Uh oh!

Uh oh!

bors commented Sep 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Stabilize `new_zeroed_alloc` #144091

Stabilize `new_zeroed_alloc` #144091

thaliaarchi commented Jul 17, 2025 •

edited by rustbot

Loading

thaliaarchi commented Jul 17, 2025 •

edited

Loading

rfcbot commented Jul 22, 2025 •

edited by joshtriplett

Loading