-
Notifications
You must be signed in to change notification settings - Fork 13.8k
TypeTree support in autodiff #144197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TypeTree support in autodiff #144197
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e1258e7
autodiff: Add basic TypeTree with NoTT flag
KMJ-007 375e14e
Add TypeTree metadata attachment for autodiff
KMJ-007 beba6b9
Update TypeTree tests to verify metadata attachment
KMJ-007 5d3ebc3
Add TypeTree tests for scalar types
KMJ-007 664e83b
added typetree support for memcpy
KMJ-007 b8bb2e8
typo: allow EnzymeTypeTreeShiftIndiciesEq
KMJ-007 d89ee85
enzyme submodule updated
KMJ-007 54f9376
autodiff: f128 support added for typetree
KMJ-007 31541fe
autodiff: add TypeTree support for arrays
KMJ-007 be3617b
autodiff: slice support in typetree
KMJ-007 7c5fbfb
autodiff: tuple support in typetree
KMJ-007 574f0b9
autodiff: struct support in typetree
KMJ-007 4f3f0f4
autodiff: fixed test to be more precise for type tree checking
KMJ-007 4520926
autodiff: recurion added for typetree
KMJ-007 3ba5f19
autodiff: typetree recursive depth query from enzyme with fallback
KMJ-007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ pub enum Kind { | |
Half, | ||
Float, | ||
Double, | ||
F128, | ||
Unknown, | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,7 @@ mod llvm_util; | |
mod mono_item; | ||
mod type_; | ||
mod type_of; | ||
mod typetree; | ||
mod va_arg; | ||
mod value; | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for making a separate datastructure here on the rust side and converting it to an Enzyme TypeTree, instead of just calling the API for Enzyme's TypeTree directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, this was already there, @ZuseZ4 can tell, but I will check again and will remove it
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the rustc frontend (rustc_ast) shouldn't depend on an optional plugin for the LLVM backend, which itself is only one out of multiple rustc backends. We generally try to avoid directly using unsafe LLVM / C functions.