Add aarch64_be-unknown-linux-musl target #144551
Conversation
rustbot
added
S-waiting-on-author
compiler/rustc_target/src/spec/targets/aarch64_be_unknown_linux_musl.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_target/src/spec/targets/aarch64_be_unknown_linux_musl.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
r? compiler_leads |
| ## Requirements | ||
|
|
||
| The target requires a `aarch64_be-*-linux-musl` toolchain, which likely has to | ||
| be built from source because this is a rare combination. [Buildroot] provides |
There was a problem hiding this comment.
I just noticed that musl.cc/musl-cross-make includes an aarch64_be toolchain, which necessitates some rephrasing in this paragraph.
There was a problem hiding this comment.
Could you also include the completed target tier policy compliance affirmations like in the description of #144962 (comment)?
| let mut base = base::linux_musl::opts(); | ||
| base.max_atomic_width = Some(128); | ||
| base.supports_xray = true; | ||
| base.features = "+v8a".into(); |
There was a problem hiding this comment.
Should outline-atomics be included here, as per #144429?
| arch: "aarch64".into(), | ||
| options: TargetOptions { | ||
| mcount: "\u{1}_mcount".into(), | ||
| endian: Endian::Big, |
There was a problem hiding this comment.
Is there a reason the frame_pointer changes to the aarch64-unknown-linux-musl target wouldn't also apply to this target?
rustbot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #145366) made this pull request unmergeable. Please resolve the merge conflicts. |
This PR adds a target definition for big-endian Aarch64 with musl-libc.
cc @Gelbpunkt