-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases #144565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash this, and it would be useful if you actually described what effect these changes had and why they're only important for RISCV codegen.
Insufficient permissions to issue commands to rust-timer. |
@CaiWeiran: 🔑 Insufficient privileges: not in try users |
Insufficient permissions to issue commands to rust-timer. |
☔ The latest upstream changes (presumably #145423) made this pull request unmergeable. Please resolve the merge conflicts. |
This PR addresses and resolves several test failures that occurred when running
./x test
on the RISC-V architecture. The issues were due to platform-specific behavior, ABI differences, or code generation inconsistencies specific to RISC-V.The following tests have been fixed:
codegen-llvm/enum/enum-match.rs
codegen-llvm/enum/enum-transparent-extract.rs
codegen-llvm/repeat-operand-zero-len.rs
codegen-llvm/enum/enum-aggregate.rs
codegen-llvm/uninhabited-transparent-return-abi.rs
All changes have been tested locally with
./x test
on a RISC-V target and now pass as expected.Notes: