Cache param_env on disk.

[cjgillot]

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit 94bea3e with merge 7613872…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 7613872 (76138721749852fe37d3834fd31a59668da3009e, parent: f34ba774c78ea32b7c40598b8ad23e75cdac42a6)

[compiler-errors]

r=me if this is positive.

you may also want to try out cache_on_disk_if { !def_id.is_local() } since upstream definitions certainly do not change given incremental.

It would be nice to cache those upstream param-envs anyways but it's expensive: #141450. I fucked something up with the impl but it still was pretty dramatic slowdown.

[rust-timer]

Finished benchmarking commit (7613872): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.2%, 7.9%]	90
Regressions ❌ (secondary)	0.7%	[0.1%, 2.4%]	63
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-1.2%, -0.0%]	6
All ❌✅ (primary)	1.1%	[0.2%, 7.9%]	90

Max RSS (memory usage)

Results (primary 1.1%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.4%, 1.8%]	19
Regressions ❌ (secondary)	4.3%	[1.7%, 7.8%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[0.4%, 1.8%]	19

Cycles

Results (primary 2.0%, secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.8%	[2.3%, 5.0%]	5
Regressions ❌ (secondary)	12.1%	[3.9%, 27.5%]	3
Improvements ✅ (primary)	-2.3%	[-2.6%, -2.0%]	2
Improvements ✅ (secondary)	-2.5%	[-3.0%, -2.2%]	3
All ❌✅ (primary)	2.0%	[-2.6%, 5.0%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.629s -> 466.495s (-0.24%)
Artifact size: 376.97 MiB -> 377.01 MiB (0.01%)