resolve: Introduce RibKind::Block
#145065
Open
+99
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
petrochenkov
commented
Aug 7, 2025
| /// Behaves like `Normal`, but also partially like `Module` if the block contains items. | ||
| /// `Block(None)` must be always processed in the same way as `Block(Some(module))` | ||
| /// with empty `module`. The module can be `None` only because creation of some definitely | ||
| /// empty modules is skipped as an optimization. |
There was a problem hiding this comment.
If the optimization is removed, some diagnostics in UI tests still change, but due to other issues, like considering only a single immediate Module parent instead of walking the chain.
This comment was marked as resolved.
This comment was marked as resolved.
bvanjoi
reviewed
Aug 11, 2025
to avoid confusing module items, blocks with items, and blocks without items.
davidtwco
approved these changes
Aug 13, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 14, 2025
resolve: Introduce `RibKind::Block` to avoid confusing module items, blocks with items, and blocks without items. Addresses rust-lang#143141 (comment) and rust-lang#143141 (comment). A couple of related cleanups are also added on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid confusing module items, blocks with items, and blocks without items.
Addresses #143141 (comment) and #143141 (comment).
A couple of related cleanups are also added on top.