Skip to content

resolve: Do not finalize shadowed bindings #145113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

resolve: Do not finalize shadowed bindings #145113

wants to merge 1 commit into from
+12 −15

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Aug 8, 2025 •
edited
Loading

I.e. do not mark them as used, or non-speculatively loaded, or similar.
Previously they were sometimes finalized during early resolution, causing issues like #144793 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
@petrochenkov petrochenkov mentioned this pull request Aug 8, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

Looks like this triggers a new unused warning in the stdlib? Is this intentional? We probably should crater this if so.

@bors2 try
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2025
@rust-bors
Copy link

rust-bors bot commented Aug 8, 2025

⌛ Trying commit 5feb92e with merge 8c500c7…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Aug 8, 2025
@rust-bors
Auto merge of #145113 - petrochenkov:lessfinalize, r=<try>
8c500c7 
resolve: Do not finalize shadowed bindings
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Aug 8, 2025 •
edited
Loading

Looks like this triggers a new unused warning in the stdlib? Is this intentional?

Yes, some new unused items can be detected now.
It shouldn't be common though.

@rust-bors
Copy link

rust-bors bot commented Aug 8, 2025

☀️ Try build successful (CI)
Build commit: 8c500c7 (8c500c7cefd54fd11d57295f3771d576be9ee415, parent: 2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a)

@BoxyUwU BoxyUwU removed their assignment Aug 8, 2025
@petrochenkov
Copy link
Contributor Author

We probably should crater this if so.

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-145113 created and queued.
🤖 Automatically detected try build 8c500c7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-145113 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@compiler-errors compiler-errors self-assigned this Aug 9, 2025
@craterbot
Copy link
Collaborator

🎉 Experiment pr-145113 is completed!
📊 15 regressed and 3 fixed (679020 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 10, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) O-unix Operating system: Unix-like labels Aug 11, 2025
@petrochenkov
Copy link
Contributor Author

🎉 Experiment pr-145113 is completed! 📊 15 regressed and 3 fixed (679020 total) 📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist! ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

A few new unused import lints, as expected.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@petrochenkov
Copy link
Contributor Author

I have no idea how to build rust-analyzer to reproduce those errors, ./x t rust-analyzer does not show them.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Veykril
Copy link
Member

Veykril commented Aug 12, 2025

I have no idea how to build rust-analyzer to reproduce those errors, ./x t rust-analyzer does not show them.

x test does not yet test and built the whole of rust-analyzer, so you need to x check it

@bors

This comment was marked as resolved.

Sign in to view
@petrochenkov
resolve: Do not finalize shadowed bindings
581051e 
I.e. do not mark them as used, or non-speculative loaded, or similar.
Previously they were sometimes finalized during early resolution, causing issues like rust-lang#144793 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rustbot @rust-log-analyzer @compiler-errors @craterbot @Veykril @bors @BoxyUwU