-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Rollup of 21 pull requests #145192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 21 pull requests #145192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a very hacky regex that will probably miss some variables. But having some docs seems better than none at all. This uses a very hacky regex that will probably miss some variables. But having some docs seems better than none at all. In particular, this generates stubs for the following env vars: - COLORTERM - QNX_TARGET - RUST_BACKTRACE - RUSTC_BLESS - RUSTC_BOOTSTRAP - RUSTC_BREAK_ON_ICE - RUSTC_CTFE_BACKTRACE - RUSTC_FORCE_RUSTC_VERSION - RUSTC_GRAPHVIZ_FONT - RUSTC_ICE - RUSTC_LOG - RUSTC_OVERRIDE_VERSION_STRING - RUSTC_RETRY_LINKER_ON_SEGFAULT - RUSTC_TRANSLATION_NO_DEBUG_ASSERT - RUST_DEP_GRAPH_FILTER - RUST_DEP_GRAPH - RUST_FORBID_DEP_GRAPH_EDGE - RUST_MIN_STACK - RUST_TARGET_PATH - SDKROOT - TERM - UNSTABLE_RUSTDOC_TEST_LINE - UNSTABLE_RUSTDOC_TEST_PATH [rendered]()
…ependencies Signed-off-by: Jonathan Brouwer <[email protected]>
…ibutes explicitly
The suboptimal error only appears with NLLs due to liveness differences where polonius cannot have as many boring locals. Sometimes this causes NLLs to emit a duplicate error as well.
Remove incomplete handling of kills during traversal for loan liveness to get to a simpler and actionable prototype. This handles the cases, on sufficiently simple examples, that were deferred from NLLs (NLL problem case 3, lending iterators), and is still a good step to put in people's hands without needing to wait for another full implementation. This is a practical cut in scope, but it also shows where are the areas of improvement, that we will explore in the future.
These are just some sanity checks to ensure NLLs, the polonius alpha analysis, and the datalog implementation behave the same on these common examples.
This test showcases the same imprecision as NLLs, unlike the datalog implementation, when using reachability as a liveness approximation.
This is an example similar to the linked-list cursor examples where the alpha shows the same imprecision as NLLs, but that can work due to the loans not being live after the loop, or the constraint graph being simple enough that the cfg/subset relationships are the same for reachability and liveness.
- linked-list cursor-like patterns - issue-46589 These are known-bugs for the polonius alpha, where they show the same imprecision as NLLs, but are supported by the old datalog implementation.
also add a note to `GenericArgs::truncate_to`
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort
Co-authored-by: Florian Bartels <[email protected]> Co-authored-by: Mads Marquart <[email protected]>
This (poorly named) target option controls whether or not cdylibs will export mangled rust symbols rather than just unmangled symbols. Presumably at some point in the past support for this wasn't implemented yet for Solaris, but cg_ssa::back::linker does have handling for this on Solaris now. And one of the Solaris target maintainers confirmed that building Rust with this option enabled works fine for them on Solaris.
rustdoc has its own issue template now, mention that. swap the order of the last two sentances so it reads more like a typical if/else chain (base case listed last). adjust some labels and descriptions
@bors r+ rollup=never p=5 |
@bors try jobs=test-various,dist-ohos-x86_64 |
rust-bors bot
added a commit
that referenced
this pull request
Aug 10, 2025
Rollup of 21 pull requests try-job: test-various try-job: dist-ohos-x86_64
The job Click to see the possible cause of the failure (guessed by this bot)
|
Huh, something is failing tidy. @bors r- |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed (CI). Failed jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-attributes
Area: Attributes (`#[…]`, `#![…]`)
A-compiletest
Area: The compiletest test runner
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
A-tidy
Area: The tidy tool
PG-exploit-mitigations
Project group: Exploit mitigations
rollup
A PR which is a rollup
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_ops
#143949 (Constify remaining traits/impls forconst_ops
)tests/ui/issues/
: The Issues Strike Back [4/N] #144403 (tests/ui/issues/
: The Issues Strike Back [4/N])ILL_FORMED_ATTRIBUTE_INPUT
in dependencies #144544 (Start reporting future breakage forILL_FORMED_ATTRIBUTE_INPUT
in dependencies)ERROR_EXIT_CODE
constant in rustdoc #144739 (Use new public libtestERROR_EXIT_CODE
constant in rustdoc)/machine:arm64ec
when linking LLVM as Arm64EC #145129 ([win][arm64ec] Add/machine:arm64ec
when linking LLVM as Arm64EC)duration_constructors_lite
feature #145135 (Stabilizeduration_constructors_lite
feature)derive_more
refactors #145145 (somederive_more
refactors)TraitRef::from_method
tofrom_assoc
#145147 (renameTraitRef::from_method
tofrom_assoc
)eq_ignore_ascii_case
to avoid heap alloc indetect_confuse_type
#145152 (Useto_ascii_lowercase
to avoid heap alloc indetect_confuse_type
)#[allow_internal_unsafe]
to the new attribute system (attempt 2) #145155 (Port#[allow_internal_unsafe]
to the new attribute system (attempt 2))build-dir
in bootstrap #145156 (Override custom Cargobuild-dir
in bootstrap){BTree,Hash}Map
: add "Entry
API" section heading #145162 ({BTree,Hash}Map
: add "Entry
API" section heading)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup