Fix Crash when indexing into a generic slice with computed length in const fns #145213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
eval-exec
changed the title
eval-exec
force-pushed
the
fix-145138
branch
3 times, most recently
from
afb201b to
e7cec14
Compare
This comment has been minimized.
This comment has been minimized.
…const fns Signed-off-by: Eval EXEC <[email protected]>
lcnr
reviewed
Aug 13, 2025
| ty::ConstKind::Param(_) | ty::ConstKind::Error(_) | ty::ConstKind::Value(_) => None, | ||
| // A type-level unevaluated const (e.g., from generic const exprs). Treat like a | ||
| // MIR unevaluated const so we can look up qualifs on the referenced def. | ||
| ty::ConstKind::Unevaluated(uv) => Some(mir::UnevaluatedConst::new(uv.def, uv.args)), |
Contributor
There was a problem hiding this comment.
the fact that we've got an unevaluated const ty as a constant value in the body is wrong 🤔 we should not support this but instead fix [MIR building for] GCE to not emit such a thing.
Generally, we're currently working towards a replacement of generic_const_exprs which won't have these issues, so we're currently not very actively trying to fix bugs of that feature
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to fix #145138