std: use a TAIT to define SplitPaths on UNIX
#145242
Open
+7
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
O-unix
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Note that this does not concern the public |
library/std/src/sys/pal/unix/os.rs
Outdated
| pub struct SplitPaths<'a> { | ||
| iter: iter::Map<slice::Split<'a, u8, fn(&u8) -> bool>, fn(&'a [u8]) -> PathBuf>, | ||
| } | ||
| pub type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a; |
There was a problem hiding this comment.
Should these items be pub(crate) if so?
We'd rather not be exposing a TAIT to downstream code, I imagine, so it might be better to enforce that with proper visibility:
Suggested change
| pub type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a; | |
| pub(crate) type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a; |
There was a problem hiding this comment.
None of the items in sys is exposed publicly, but we still use pub instead of pub(crate) almost everywhere. I don't really want to break the pattern and cause unnecessary confusion.
joboet
force-pushed
the
tait-split-paths
branch
from
3a4164f to
cb388c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining
SplitPathsas a TAIT allows using closures instead of function pointers forsplitandmap.