-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Make sure to treat only param where clauses as inherent #145262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make sure to treat only param where clauses as inherent #145262
Conversation
@@ -1945,6 +1945,29 @@ impl<'a, 'tcx> ProbeContext<'a, 'tcx> { | |||
); | |||
(xform_self_ty, xform_ret_ty) = | |||
self.xform_self_ty(probe.item, trait_ref.self_ty(), trait_ref.args); | |||
|
|||
if matches!(probe.kind, WhereClauseCandidate(_)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could fast path this for the old trait solver, since we expect things to be normalized always.
@bors2 try @rust-timer queue I also want to crater this since it may cause some code to fail due to new ambiguity and missing imports. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Make sure to treat only param where clauses as inherent
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (987a165): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.2%, secondary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 464.993s -> 463.982s (-0.22%) |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
0.0% perf regression is definitely important good job perfbot 👍 |
See the description in the test file.
This PR fixes a bug introduced by #141333, where we considered non-
Param
where clauses to be "inherent" for the purpose of method probing, which leads to both changes in method ambiguity (see test) and also import usage linting (and thus fixes #145185).r? @lcnr