Constify conversion traits (part 1) #145279
Open
+261
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
clarfonthey
commented
Aug 11, 2025
| #![feature(const_default)] | ||
| #![feature(const_eval_select)] | ||
| #![feature(const_heap)] | ||
| #![feature(const_trait_impl)] |
There was a problem hiding this comment.
Was listed under library features, and is actually a language feature. Since the diff doesn't make that clear.
clarfonthey
commented
Aug 11, 2025
Comment on lines
+117
to
+121
| // FIXME(const-hack): this should use map_err instead | ||
| match u8::try_from(u32::from(c)) { | ||
| Ok(b) => Ok(b), | ||
| Err(_) => Err(TryFromCharError(())), | ||
| } |
There was a problem hiding this comment.
You mentioned not wanting to add any more const-hacks, but I figured this one (+ for u16 below) was okay because we're already going to have to fix a lot of const code once things are stable, and I think that simple char <-> integer conversions are useful enough to get on nightly sooner. Especially since const closures seem pretty far off at the moment.
|
☔ The latest upstream changes (presumably #145334) made this pull request unmergeable. Please resolve the merge conflicts. |
clarfonthey
force-pushed
the
const-convert-initial
branch
from
365fcde to
97c330f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #144289 being split into smaller pieces. It adds/moves constness of several traits under the
const_convertfeature:FromIntoTryFromTryIntoFromStrAsRefAsMutBorrowBorrowMutDerefDerefMutThere are a few methods that are intrinsically tied to these traits which I've included in the feature. Particularly, those which are wrappers over
AsRef:ByteStr::new(unstable underbstrfeature)OsStr::newPath::newThose which directly use
Into:Result::into_okResult::into_errAnd those which use
DerefandDerefMut:Pin::as_refPin::as_mutPin::as_deref_mutThe parts which are missing from this PR are:
OsStrorPath(note: this mostly makes these methods useless sincestrdoesn't implementAsRef<OsStr>yet, but it's better to track the method for now and add impls later, IMHO)r? @tgross35 (who mostly already reviewed this)