Rollup of 16 pull requests #145280

fmease · 2025-08-11T23:51:05Z

Successful merges:

Apple: Always pass SDK root when linking with cc, and pass it via SDKROOT env var #131477 (Apple: Always pass SDK root when linking with cc, and pass it via SDKROOT env var)
std: sys: pal: uefi: Overhaul Time #139806 (std: sys: pal: uefi: Overhaul Time)
std: thread: Return error if setting thread stack size fails #144210 (std: thread: Return error if setting thread stack size fails)
Extract TraitImplHeader in AST/HIR #144386 (Extract TraitImplHeader in AST/HIR)
Stabilize sse4a and tbm target features #144542 (Stabilize sse4a and tbm target features)
Don't emit rustdoc::broken_intra_doc_links for GitHub-flavored Markdown admonitions like [!NOTE] #144921 (Don't emit rustdoc::broken_intra_doc_links for GitHub-flavored Markdown admonitions like [!NOTE])
run spellcheck as a tidy extra check in ci #145025 (run spellcheck as a tidy extra check in ci)
Port #[allow_internal_unsafe] to the new attribute system (attempt 2) #145155 (Port #[allow_internal_unsafe] to the new attribute system (attempt 2))
fix: re-enable self-assignment #145214 (fix: re-enable self-assignment)
rustdoc: correct negative-to-implicit discriminant display #145216 (rustdoc: correct negative-to-implicit discriminant display)
Tweak invalid builtin attribute output #145238 (Tweak invalid builtin attribute output)
Rename entered trace span variables from _span to _trace #145249 (Rename entered trace span variables from _span to _trace)
Support using #[unstable_feature_bound] on trait #145251 (Support using #[unstable_feature_bound] on trait)
Document compiler and stdlib in stage1 in pr-check-2 CI job #145253 (Document compiler and stdlib in stage1 in pr-check-2 CI job)
Make explicit guarantees about Vec’s allocator #145260 (Make explicit guarantees about Vec’s allocator)
Update books #145263 (Update books)

Failed merges:

Constify SystemTime methods #144519 (Constify SystemTime methods)

r? @ghost
@rustbot modify labels: rollup

Currently, when setting the thread stack size fails, it would be rounded up to the nearest multiple of the page size and the code asserts that the next call to pthread_attr_setstacksize succeeds. This may be true for glibc, but it isn't true for musl, which not only enforces a minimum stack size, but also a maximum stack size of usize::MAX / 4 - PTHREAD_STACK_MIN [1], triggering the assert rather than erroring gracefully. There isn't any way to handle this properly other than bailing out and letting the user know it didn't succeed. [1]: https://git.musl-libc.org/cgit/musl/tree/src/thread/pthread_attr_setstacksize.c#n5 Signed-off-by: Jens Reidel <[email protected]>

…rect signedness

_span could possibly be confused with the Span type in rustc

Use a time representation with 1900-01-01-00:00:00 at timezone -1440 min as anchor. This is the earliest time supported in UEFI. Signed-off-by: Ayush Singh <[email protected]>

Add tests to ensure that extream system times are still representable. Signed-off-by: Ayush Singh <[email protected]>

…medValueStr` Modify `AttributeTemplate` to support list of alternatives for list and name value attribute styles. Suggestions now provide more correct suggested code: ``` error[E0805]: malformed `used` attribute input --> $DIR/used_with_multi_args.rs:3:1 | LL | #[used(compiler, linker)] | ^^^^^^------------------^ | | | expected a single argument here | help: try changing it to one of the following valid forms of the attribute | LL - #[used(compiler, linker)] LL + #[used(compiler)] | LL - #[used(compiler, linker)] LL + #[used(linker)] | LL - #[used(compiler, linker)] LL + #[used] | ``` instead of the prior "masking" of the lack of this feature by suggesting pipe-separated lists: ``` error[E0805]: malformed `used` attribute input --> $DIR/used_with_multi_args.rs:3:1 | LL | #[used(compiler, linker)] | ^^^^^^------------------^ | | | expected a single argument here | help: try changing it to one of the following valid forms of the attribute | LL - #[used(compiler, linker)] LL + #[used(compiler|linker)] | LL - #[used(compiler, linker)] LL + #[used] | ```

This commit amends the documentation of `Vec::as_mut_ptr` and `Vec::into_raw_parts` to make it explicit that such calls may be paired with calls to `dealloc` with a suitable layout. This guarantee was effectively already provided by the docs of `Vec::from_raw_parts` mentioning `alloc`. Additionally, we copy-paste and adjust the “Memory layout” section from the documentation of `std::boxed` to `std::vec`. This explains the allocator guarantees in more detail.

- remove some stabilized target features from `gate.rs`

fmease · 2025-08-11T23:51:17Z

@bors r+ rollup=never p=5

bors · 2025-08-11T23:51:19Z

📌 Commit 590eae8 has been approved by fmease

It is now in the queue for this repository.

fmease · 2025-08-11T23:56:22Z

While we're waiting, let's run a basic try-job.

@bors try

rust-bors · 2025-08-11T23:56:26Z

⌛ Trying commit 590eae8 with merge 9d1719a…

To cancel the try build, run the command @bors try cancel.

Rollup of 16 pull requests

clarfonthey · 2025-08-11T23:58:22Z

Note: I tried to get bors to remove #144519 from the queue but it wouldn't let me. #139806 and my PR almost certainly conflict, and I'm fine deferring my PR until after.

rust-log-analyzer · 2025-08-11T23:59:25Z

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 \
  src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#15 3.339 Building wheels for collected packages: reuse
#15 3.340   Building wheel for reuse (pyproject.toml): started
#15 3.561   Building wheel for reuse (pyproject.toml): finished with status 'done'
#15 3.562   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132719 sha256=d2a2565e7037ad3883fb9337653f2e25bbb588534fbef3697286cbc26d1bf634
#15 3.562   Stored in directory: /tmp/pip-ephem-wheel-cache-6xq018f6/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#15 3.564 Successfully built reuse
#15 3.565 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#15 3.980 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#15 3.980 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#15 4.539 Collecting virtualenv
---
DirectMap4k:      145344 kB
DirectMap2M:     4048896 kB
DirectMap1G:    14680064 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0   src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: `rust.debug-assertions = true` will prevent downloading CI rustc as alt CI rustc is not currently built with debug assertions.
downloading https://static.rust-lang.org/dist/2025-08-06/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
checking python file formatting
27 files already formatted
checking C++ file formatting
spellcheck files
building external tool typos from package [email protected]
finished building tool typos
error: `moreso` should be `more`
##[error]  --> compiler/rustc_codegen_ssa/src/back/apple.rs:177:43
    |
177 |             // in a manner unknown to us (moreso if cross-compiling):
    |                                           ^^^^^^
    |
error: `modifed` should be `modified`
##[error]  --> library/std/src/sys/pal/uefi/time.rs:178:29
    |
178 |     /// This algorithm is a modifed version of the one described in the post:
    |                             ^^^^^^^
    |
error: `stablized` should be `stabilized`
##[error]  --> library/std/src/sys/pal/uefi/time.rs:187:56
    |
187 |         // FIXME(#126043): use checked_sub_signed once stablized
    |                                                        ^^^^^^^^^
    |
tidy error: checks with external tool 'typos' failed
some tidy checks failed
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1636:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1239:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:39
  local time: Mon Aug 11 23:59:15 UTC 2025
  network time: Mon, 11 Aug 2025 23:59:15 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

clarfonthey · 2025-08-12T00:00:32Z

Or! The typo checker could make that PR the one that actually needs to be fixed. .-.

fmease · 2025-08-12T00:01:39Z

@bors try cancel

rust-bors · 2025-08-12T00:01:42Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/16895101300

fmease · 2025-08-12T00:04:42Z

Welp, should I kick spellcheck out or "overhaul SystemTime" >.< hmm, I guess I'll kick spellcheck out.

fmease · 2025-08-12T00:04:48Z

@bors r-

Gelbpunkt and others added 30 commits July 26, 2025 22:34

run spellcheck as a tidy extra check in ci

c0eaad7

fix some typos in std::sync and in the compiler

002ea81

tidy now installs typos-cli as-needed via cargo

814dec7

ensure_version_or_cargo_install: reinstate version check

315fb73

ensure_version_or_cargo_install: logging and assert

b2b36e7

tidy: add better error reporting for if typos can't be run

1a288a8

ensure_version_or_cargo_install: don't hardcode path to cargo

841448b

tidy: run typos check in src root, not current dir

cedad9c

fix even more typos

715bbe0

fix: re-enable self-assignment

ba350ff

test: Add rustdoc test for enum negative overflow

de13718

rustdoc: Use discrs Display impl to render the value with the cor…

20a134f

…rect signedness

tidy spellcheck improvments based on code review

3252f85

Turn _span into _trace as trace span name

cd4676c

_span could possibly be confused with the Span type in rustc

Port #[allow_internal_unsafe] to the new attribute system (attempt 2)

6603fe1

Support using #[unstable_feature_bound] on trait

d523b9f

Update rustc dev guide

9a8facb

Update error message

bcf87e4

std: sys: pal: uefi: Overhaul Time

0ccbe8f

Use a time representation with 1900-01-01-00:00:00 at timezone -1440 min as anchor. This is the earliest time supported in UEFI. Signed-off-by: Ayush Singh <[email protected]>

std: sys: pal: uefi: tests: Add systemtime tests

35906ea

Add tests to ensure that extream system times are still representable. Signed-off-by: Ayush Singh <[email protected]>

Document compiler and stdlib in stage1 in pr-check-2 CI job

79a134a

don't emit rustdoc::broken_intra_doc_links for stuff like [!NOTE]

c022ed9

Add link to docs on malformed attributes

625143b

Add link to invalid repr error

6bb29af

fix tests

413ca5d

Stabilize sse4a and tbm target features

3200d1f

- remove some stabilized target features from `gate.rs`

Update books

50d8b80

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025

rust-bors bot added a commit that referenced this pull request Aug 11, 2025

Auto merge of #145280 - fmease:rollup-q39klge, r=<try>

9d1719a

Rollup of 16 pull requests

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 12, 2025

fmease mentioned this pull request Aug 12, 2025

run spellcheck as a tidy extra check in ci #145025

Open

fmease closed this Aug 12, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2025

fmease deleted the rollup-q39klge branch August 12, 2025 00:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 16 pull requests #145280

Rollup of 16 pull requests #145280

fmease commented Aug 11, 2025 •

edited by rustbot

Loading

Uh oh!

fmease commented Aug 11, 2025

Uh oh!

bors commented Aug 11, 2025

Uh oh!

fmease commented Aug 11, 2025

Uh oh!

rust-bors bot commented Aug 11, 2025

Uh oh!

clarfonthey commented Aug 11, 2025

Uh oh!

rust-log-analyzer commented Aug 11, 2025

Uh oh!

clarfonthey commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

rust-bors bot commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

Uh oh!

Rollup of 16 pull requests #145280

Rollup of 16 pull requests #145280

Conversation

fmease commented Aug 11, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Aug 11, 2025

Uh oh!

bors commented Aug 11, 2025

Uh oh!

fmease commented Aug 11, 2025

Uh oh!

rust-bors bot commented Aug 11, 2025

Uh oh!

clarfonthey commented Aug 11, 2025

Uh oh!

rust-log-analyzer commented Aug 11, 2025

Uh oh!

clarfonthey commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

rust-bors bot commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

fmease commented Aug 12, 2025

Uh oh!

Uh oh!

fmease commented Aug 11, 2025 •

edited by rustbot

Loading