Resolve the prelude import in build_reduced_graph

[LorrensP-2158466]

This pr tries to resolve the prelude import at the build_reduced_graph stage.
Part of batched import resolution in #145108 (cherry picked commit) and maybe needed for #139493.

r? petrochenkov

[petrochenkov]

Could you avoid calling add_import for prelude imports entirely?
And remove the is_prelude field from ImportKind::Glob.

[LorrensP-2158466]

I don't think its avoidable, maybe_resolve_path takes an ignore_import, which is the glob_import itself.

[petrochenkov]

ignore_import can be None here, it doesn't make sense during the prelude import resolution.

[petrochenkov]

Could you immediately report an error if maybe_resolve_path returns anything other than PathResult::Module(ModuleOrUniformRoot::Module(..))?
Just some error, having a good error here is not important since it's an implementation detail.

[LorrensP-2158466]

Not possible I think, in library/core/src/lib.rs there is:

#[prelude_import]
#[allow(unused)]
use prelude::rust_2024::*;

Which failed and thus throws the error.

[petrochenkov]

The import needs to be put after mod prelude;.
It's an internal detail so we can do that.

[LorrensP-2158466]

That was it, thanks!

[petrochenkov]

Could you avoid calling maybe_resolve_path and setting the prelude if it is already set?
Can also report some error in that case.

[petrochenkov]

Could you also add this case to tests?

//@ check-pass

#![feature(custom_inner_attributes)]

#![rustfmt::skip]

fn main() {
    let _ = todo!();
}

[LorrensP-2158466]

I am currently unable to implement any of your suggestions; it is the prelude import that can not be resolved during build_reduced_graph. Which makes me think that this change doesn't actually do anything useful? At least the prelude import in stdlib keeps failing with every change.

[petrochenkov]

@Voultapher
This change should fix your issues with #139493 and custom inner attributes.
Could you check it when it's ready?

[LorrensP-2158466]

Suggestions worked, however, we can't emit an error when the prelude is already set, I just used a panic for ease of use, and it was triggered when compiling stdlib:

prelude already set: [Segment { ident: prelude#0, id: Some(NodeId(479)), has_generic_args: false, has_lifetime_args: false, args_span: no-location (#0) }, Segment { ident: rust_2021#0, id: Some(NodeId(480)), has_generic_args: false, has_lifetime_args: false, args_span: no-location (#0) }]

I also can't avoid to only resolve the prelude path when the prelude is not set. Errors like these get emitted:

error[E0433]: failed to resolve: use of undeclared type `String`
   --> library/std/src/panicking.rs:642:29
    |
642 |                 let mut s = String::new();
    |                             ^^^^^^ use of undeclared type `String`
    |
help: consider importing one of these structs
    |
 12 + use crate::prelude::rust_future::String;
    |
 12 + use alloc::string::String;
    |

error[E0433]: failed to resolve: use of undeclared type `Box`
   --> library/std/src/panicking.rs:656:13
    |
656 |             Box::into_raw(Box::new(contents))
    |             ^^^ use of undeclared type `Box`
    |
help: consider importing one of these structs
    |
 12 + use crate::prelude::rust_future::Box;
    |
 12 + use alloc::boxed::Box;

@rustbot ready