Port the #[linkage] attribute to the new attribute system
#145323
+187
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing |
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqwvmznzzmpr
branch
from
4e42223 to
f51108d
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pqwvmznzzmpr
branch
from
f51108d to
0e45ceb
Compare
| AttributeKind::Linkage(linkage, _) => { | ||
| let linkage = match linkage { | ||
| LinkageArg::AvailableExternally => Linkage::AvailableExternally, | ||
| LinkageArg::Common => Linkage::Common, |
There was a problem hiding this comment.
it looks like maybe the attribute can just contain a Linkage directly since this looks like a one-to-one map
|
looks good otherwise |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann