Switch next solver to use a specific associated type for trait def id #145377
+227
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
ChayimFriedman2
force-pushed
the
solver-def-id
branch
from
a370dc8 to
a854097
Compare
This comment has been minimized.
This comment has been minimized.
The compiler just puts `DefId` in there, but rust-analyzer uses different types for each kind of item.
ChayimFriedman2
force-pushed
the
solver-def-id
branch
from
a854097 to
e854390
Compare
|
☔ The latest upstream changes (presumably #144991) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler just puts
DefIdin there, but rust-analyzer uses different types for each kind of item.See the Zulip discussion. In short, it will be a tremendous help to r-a to use specific associated types, while for the solver and the compiler it's a small change. So I ported
TraitId, as a proof of concept and it's also likely the most impactful.r? types