Remove TmpLayout in layout_of_enum #145387
Open
+9
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
09a3846 from #103693 made LayoutData be owned instead of interned in
Variants::Multiple::variants
1, so there's no need forTmpLayout
in layout_of_enum anymore, and we can just store the variants' layouts directly in the prospectiveLayoutData
s'variants
fields.This should have no effect on semantics or layout.
(written as part of #145337 but not related to the layout optimizations in that PR)
Footnotes
see line 1154 of
compiler/rustc_target/src/abi/mod.rs
in the linked commit;Variants::Multiple::variants
effectively changed fromIndexVec<.., Layout<'tcx>>
toIndexVec<.., LayoutData>
where theLayoutData
s are not interned asLayout
s (LayoutData
was at the time calledLayoutS
) ↩