Skip to content

[BETA] Revert "Remove the witness type from coroutine args" #145395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

[BETA] Revert "Remove the witness type from coroutine args" #145395

wants to merge 2 commits into from
+150 −54

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 14, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 14, 2025
lqd
lqd approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@compiler-errors

This comment was marked as off-topic.

Sign in to view
@compiler-errors

This comment was marked as off-topic.

Sign in to view
@jieyouxu
Copy link
Member

(For quicker context, this is the revert approach instead of beta-backporting both #145194 and #145338)

@petrochenkov
Copy link
Contributor

r=me once this is beta-accepted.
(Not sure how the new process with t-compiler/backports works.)
@rustbot team

@petrochenkov petrochenkov added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees

@petrochenkov petrochenkov

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rustbot @compiler-errors @jieyouxu @petrochenkov @lqd