Fix format string grammar in docs and improve alignment error message for #144023 #145591
Conversation
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Currently they are skipped, which is a bit weird, and it sometimes causes malformed output like `Foo<>` and `dyn Bar<, A = u32>`. Most regions are erased by the time `type_name` does its work. So all regions are now printed as `'_` in non-optional places. Not perfect, but better than the status quo. `c_name` is updated to trim lifetimes from MIR pass names, so that the `PASS_NAMES` sanity check still works. It is also renamed as `simplify_pass_type_name` and made non-const, because it doesn't need to be const and the non-const implementation is much shorter. The commit also renames `should_print_region` as `should_print_optional_region`, which makes it clearer that it only applies to some regions. Fixes rust-lang#145168.
This handles various kinds of errors, but does not allow applying the derive yet. This adds the feature gate `macro_derive`.
Add infrastructure to apply a derive macro to arguments, consuming and returning a `TokenTree` only. Handle `SyntaxExtensionKind::MacroRules` when expanding a derive, if the macro's kinds support derive. Add tests covering various cases of `macro_rules` derives. Note that due to a pre-existing FIXME in `expand.rs`, derives are re-queued and some errors get emitted twice. Duplicate diagnostic suppression makes them not visible, but the FIXME should still get fixed.
set * Enforce the `-Zregparm=N` flag by setting the NumRegisterParameters LLVM module flag * Add assembly tests verifying that the parameters are passed in registers for reparm values 1, 2, and 3, for both LLVM intrinsics and non-builtin functions * Add c_void type to minicore
this fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change
The target is removed by `copy_link` too, so no need to duplicate the syscall.
"privalage" -> "privilege"
Migrate the standard library from using the external `cfg_if` crate to
using the now-built-in `cfg_select` macro.
This does not yet eliminate the dependency from
`library/std/Cargo.toml`, because while the standard library itself no
longer uses `cfg_if`, it also incorporates the `backtrace` crate, which
does.
Migration assisted by the following vim command (after selecting the
full `cfg_if!` invocation):
```
'<,'>s/\(cfg_if::\)\?cfg_if/cfg_select/ | '<,'>s/^\( *\)} else {/\1}\r\1_ => {/c | '<,'>s/^\( *\)} else if #\[cfg(\(.*\))\] /\1}\r\1\2 => /e | '<,'>s/if #\[cfg(\(.*\))\] {/\1 => {/e
```
This is imperfect, but substantially accelerated the process. This
prompts for confirmation on the `} else {` since that can also appear
inside one of the arms. This also requires manual intervention to handle
any multi-line conditions.
The previous code inside `cfg_if!` wasn't indented, so the conversion to `cfg_select!` left it not indented. Indent it.
nilotpal-n7
force-pushed
the
fix-format-alignment
branch
from
f62e61e to
8dac33d
Compare
rustbot
added
A-attributes
rustbot
added
A-run-make
|
Some changes occurred in src/tools/cargo cc @ehuss Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_hir/src/attrs This PR modifies cc @jieyouxu Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to the CTFE machinery |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
nilotpal-n7
force-pushed
the
fix-format-alignment
branch
from
8dac33d to
bbc659d
Compare
|
rustbot
removed
the
S-waiting-on-review
16 participants
This PR improves error messages and documentation for format strings involving alignment and formatting traits.
Highlights:
Clearer error messages for invalid alignment specifiers (e.g.,
{0:#X>18}), showing the expected<,^, or>and a working example:println!("{0:>#18X}", value);
Updated UI test
format-alignment-hash.rsto reflect the improved error output.Documentation clarification: ensures examples correctly show how width, alignment, and traits like
x,X,#combine.Motivation:
Previously, using
#with alignment and width produced confusing errors. This PR guides users on the correct syntax and provides actionable examples.Testing:
./x build)./x. test src/test/ui/fmt/format-alignment-hash.rs --bless)./x test)Issue: #144023