Skip to content

Promote aarch64-pc-windows-msvc to Tier 1 #145682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Promote aarch64-pc-windows-msvc to Tier 1 #145682

merged 1 commit into from
Sep 4, 2025

Conversation

dpaoliello
Copy link
Contributor

Per rust-lang/rfcs#3817

Tracking issue: #145671

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@dpaoliello dpaoliello mentioned this pull request Aug 20, 2025
Open
2 tasks
@ehuss
Copy link
Contributor

ehuss commented Aug 20, 2025

Don't forget to update the target value:

rust/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_msvc.rs

Line 18 in 040a98a

tier: Some(2),

@ehuss
Copy link
Contributor

ehuss commented Aug 20, 2025

r? @Noratrieb maybe?

@rustbot rustbot assigned Noratrieb and unassigned ehuss Aug 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@dpaoliello
Copy link
Contributor Author

Don't forget to update the target value:

rust/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_msvc.rs

Line 18 in 040a98a

tier: Some(2),

Thanks! I did this change based on the aarch64-darwin promotion, but I guess this is new?

@dpaoliello
Copy link
Contributor Author

Looks like infra failures in the CI job?

The job was not acquired by Runner of type hosted even after multiple attempts

@jieyouxu
Copy link
Member

Githuh had an outage earlier

@dpaoliello
Copy link
Contributor Author

Ping...

@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned Noratrieb Sep 4, 2025
jieyouxu
jieyouxu approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I double-checked against other Tier 1 promotions, the CI setup and miri docs/CI. Looks right to me.

View changes since this review

@jieyouxu jieyouxu added O-aarch64-pc-windows-msvc Target: aarch64-pc-windows-msvc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 4, 2025
@rustbot rustbot mentioned this pull request Sep 4, 2025
Open
@jieyouxu
Copy link
Member

jieyouxu commented Sep 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 0a5383c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@jhpratt jhpratt mentioned this pull request Sep 4, 2025
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 4, 2025
@Zalathar
Rollup merge of rust-lang#145682 - dpaoliello:arm64tier1, r=jieyouxu
786289a 
Promote aarch64-pc-windows-msvc to Tier 1

Per <rust-lang/rfcs#3817>

Tracking issue: <rust-lang#145671>
@Zalathar Zalathar mentioned this pull request Sep 4, 2025
Closed
bors added a commit that referenced this pull request Sep 4, 2025
@bors
Auto merge of #146192 - jhpratt:rollup-mam0bss, r=jhpratt
45b9d13 
Rollup of 5 pull requests

Successful merges:

 - #145682 (Promote aarch64-pc-windows-msvc to Tier 1)
 - #145690 (Implement Integer funnel shifts)
 - #146119 (compiletest: Implement an experimental `--new-output-capture` mode)
 - #146168 (Update bootstrap's dependencies to remove winapi and old windows-sys)
 - #146182 (Don't require next-solver `ProbeRef` to be `Copy`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4c091fb into rust-lang:master Sep 4, 2025
18 of 20 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
rust-timer added a commit that referenced this pull request Sep 4, 2025
@rust-timer
Unrolled build for #145682
b7c728c 
Rollup merge of #145682 - dpaoliello:arm64tier1, r=jieyouxu

Promote aarch64-pc-windows-msvc to Tier 1

Per <rust-lang/rfcs#3817>

Tracking issue: <#145671>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
O-aarch64-pc-windows-msvc Target: aarch64-pc-windows-msvc relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dpaoliello @rustbot @ehuss @jieyouxu @bors @Noratrieb