support link modifier as-needed for raw-dylib-elf
#146027
Merged
+82
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_codegen_ssa |
|
☔ The latest upstream changes (presumably #147345) made this pull request unmergeable. Please resolve the merge conflicts. |
usamoi
force-pushed
the
raw-dylib-elf-as-needed
branch
from
f672671 to
21dd997
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ |
bors
added
S-waiting-on-bors
5 tasks
rust-timer
added a commit
that referenced
this pull request
Oct 6, 2025
Rollup merge of #146027 - usamoi:raw-dylib-elf-as-needed, r=bjorn3 support link modifier `as-needed` for raw-dylib-elf This pull request: * emits `-Wl,--as-needed` instead of `-Wl,--no-as-needed` for `raw-dylib-elf`, keeping it consistent with `dylib` * allows combination of link kind `raw-dylib` and link modifier `as-needed`, thus allowing free choice of behavior r? `@bjorn3` cc #135694 cc #99424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
-Wl,--as-neededinstead of-Wl,--no-as-neededforraw-dylib-elf, keeping it consistent withdylibraw-dyliband link modifieras-needed, thus allowing free choice of behaviorr? @bjorn3
cc #135694
cc #99424