Rollup of 5 pull requests #146409

matthiaskrgr · 2025-09-10T12:17:41Z

Successful merges:

inclusive Ranges: change end to last #144765 (inclusive Ranges: change end to last)
Implement #[rustc_align_static(N)] on statics #146178 (Implement #[rustc_align_static(N)] on statics)
CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits #146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits)
Update wasm-component-ld to 0.5.17 #146378 (Update wasm-component-ld to 0.5.17)
Trim paths less in MIR dumping #146391 (Trim paths less in MIR dumping)

r? @ghost
@rustbot modify labels: rollup

v6.17-rc5 contains the equivalent of the two commits we had here, thus move the Rust for Linux job forward to that so that we don't need the temporary commits anymore. Signed-off-by: Miguel Ojeda <[email protected]>

Keeping this up-to-date as the project itself, and its dependencies, are updated.

We need a different attribute than `rustc_align` because unstable attributes are tied to their feature (we can't have two unstable features use the same unstable attribute). Otherwise this uses all of the same infrastructure as `#[rustc_align]`.

…file

…hpratt inclusive `Range`s: change `end` to `last` Tracking issue: rust-lang#125687 ACP: rust-lang/libs-team#511

…lmann,ralfjung,traviscross Implement `#[rustc_align_static(N)]` on `static`s Tracking issue: rust-lang#146177 ```rust #![feature(static_align)] #[rustc_align_static(64)] static SO_ALIGNED: u64 = 0; ``` We need a different attribute than `rustc_align` because unstable attributes are tied to their feature (we can't have two unstable features use the same unstable attribute). Otherwise this uses all of the same infrastructure as `#[rustc_align]`. r? `@traviscross`

CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits v6.17-rc5 contains the equivalent of the two commits we had here, thus move the Rust for Linux job forward to that so that we don't need the temporary commits anymore. r? ```@lqd``` ```@Kobzol``` try-job: x86_64-rust-for-linux ```@rustbot``` label A-rust-for-linux ```@bors``` try

…-ld, r=lqd Update wasm-component-ld to 0.5.17 Keeping this up-to-date as the project itself, and its dependencies, are updated.

Trim paths less in MIR dumping With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.

matthiaskrgr · 2025-09-10T12:17:55Z

@bors r+ rollup=never p=5

bors · 2025-09-10T12:17:58Z

📌 Commit 212baec has been approved by matthiaskrgr

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #144765 (inclusive `Range`s: change `end` to `last`) - #146178 (Implement `#[rustc_align_static(N)]` on `static`s) - #146368 (CI: rfl: move job forward to Linux v6.17-rc5 to remove temporary commits) - #146378 (Update wasm-component-ld to 0.5.17) - #146391 (Trim paths less in MIR dumping) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-10T13:44:39Z

⌛ Testing commit 212baec with merge db16a09...

rust-log-analyzer · 2025-09-10T14:55:04Z

The job dist-x86_64-illumos failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Caused by:
  failed to load lockfile for /checkout/src/tools/cargo

Caused by:
  failed to get `ct-codecs` as a dependency of package `pasetors v0.7.7`
      ... which satisfies dependency `pasetors = "^0.7.7"` (locked to 0.7.7) of package `cargo-test-support v0.8.1 (/checkout/src/tools/cargo/crates/cargo-test-support)`

Caused by:
  download of ct/-c/ct-codecs failed

Caused by:
  failed to download from `https://index.crates.io/ct/-c/ct-codecs`

Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Bootstrap failed while executing `dist --host x86_64-unknown-illumos --target x86_64-unknown-illumos`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo vendor --versioned-dirs --sync /checkout/src/tools/cargo/Cargo.toml --sync /checkout/src/tools/clippy/clippy_test_deps/Cargo.toml --sync /checkout/src/tools/rust-analyzer/Cargo.toml --sync /checkout/compiler/rustc_codegen_cranelift/Cargo.toml --sync /checkout/compiler/rustc_codegen_gcc/Cargo.toml --sync /checkout/library/Cargo.toml --sync /checkout/src/bootstrap/Cargo.toml --sync /checkout/src/tools/rustbook/Cargo.toml --sync /checkout/src/tools/rustc-perf/Cargo.toml --sync /checkout/src/tools/opt-dist/Cargo.toml --sync /checkout/src/doc/book/packages/trpl/Cargo.toml /checkout/obj/build/tmp/generate-copyright-vendor [workdir=/checkout]` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/vendor.rs:79:23
Executed at: src/bootstrap/src/core/build_steps/vendor.rs:111:26

--- STDOUT vvv


Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:58:06
  local time: Wed Sep 10 14:54:21 UTC 2025
  network time: Wed, 10 Sep 2025 14:54:21 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2025-09-10T14:55:14Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-09-10T15:00:34Z

@bors retry

bors · 2025-09-10T15:09:22Z

⌛ Testing commit 212baec with merge 565a9ca...

bors · 2025-09-10T18:16:44Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 565a9ca to master...

rust-timer · 2025-09-10T18:18:14Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144765	inclusive `Range`s: change `end` to `last`	`a63162345a9b850bceb9bf138ce843f7db3f89a1` (link)
#146178	Implement `#[rustc_align_static(N)]` on `static`s	`32fab8b683ace6a10b7f80dbc471b661ff16434c` (link)
#146368	CI: rfl: move job forward to Linux v6.17-rc5 to remove temp…	`1bbf3e9d1cb0c9c70a092b136881a7a95b2969c6` (link)
#146378	Update wasm-component-ld to 0.5.17	`1d0fb15e0ef60e391c605dc9e3ae08c8cccbd3e5` (link)
#146391	Trim paths less in MIR dumping	`2a054a5820881429cd765670f8d91ce878f9555d` (link)

previous master: 7ad23f43a2

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-10T18:19:54Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7ad23f4 (parent) -> 565a9ca (this PR)

Test differences

Show 132 test diffs

Stage 0

errors::verify_passes_custom_mir_incompatible_dialect_and_phase_143: pass -> [missing] (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_144: [missing] -> pass (J0)
errors::verify_passes_custom_mir_phase_requires_dialect_142: pass -> [missing] (J0)
errors::verify_passes_custom_mir_phase_requires_dialect_143: [missing] -> pass (J0)
errors::verify_passes_repr_align_should_be_align_static_142: [missing] -> pass (J0)

Stage 1

[codegen] tests/codegen-llvm/align-static.rs: [missing] -> pass (J0)
[ui] tests/ui/attributes/malformed-static-align.rs: [missing] -> pass (J0)
[ui] tests/ui/feature-gates/feature-gate-static_align.rs: [missing] -> pass (J0)
[ui] tests/ui/static/static-align.rs: [missing] -> pass (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_143: pass -> [missing] (J2)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_144: [missing] -> pass (J2)
errors::verify_passes_custom_mir_phase_requires_dialect_142: pass -> [missing] (J2)
errors::verify_passes_custom_mir_phase_requires_dialect_143: [missing] -> pass (J2)
errors::verify_passes_repr_align_should_be_align_static_142: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/attributes/malformed-static-align.rs: [missing] -> pass (J1)
[ui] tests/ui/feature-gates/feature-gate-static_align.rs: [missing] -> pass (J1)
[ui] tests/ui/static/static-align.rs: [missing] -> pass (J1)
[codegen] tests/codegen-llvm/align-static.rs: [missing] -> pass (J3)

Additionally, 114 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 565a9ca63e9df4b223fed0da01f15e578acfb538 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 5633.1s -> 8494.4s (50.8%)
aarch64-gnu-llvm-19-2: 2583.5s -> 2126.3s (-17.7%)
x86_64-gnu-llvm-19: 2935.3s -> 2425.0s (-17.4%)
i686-gnu-2: 6391.7s -> 5440.5s (-14.9%)
x86_64-gnu-aux: 7068.3s -> 6282.8s (-11.1%)
arm-android: 6234.3s -> 5614.6s (-9.9%)
armhf-gnu: 5354.9s -> 4846.9s (-9.5%)
aarch64-gnu-debug: 4398.7s -> 4010.4s (-8.8%)
dist-aarch64-msvc: 5736.1s -> 6191.4s (7.9%)
x86_64-gnu-llvm-19-2: 6028.1s -> 5612.6s (-6.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-10T19:28:20Z

Finished benchmarking commit (565a9ca): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	3
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	3

Max RSS (memory usage)

Results (secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[0.8%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-2.0%, -0.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[5.3%, 5.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.26s -> 468.891s (-0.08%)
Artifact size: 387.51 MiB -> 387.51 MiB (0.00%)

panstromek · 2025-09-15T17:25:32Z

perf triage:

Some small regressions. I suspect the primary regressions in unicode-normalization come from #144765, because it contains a few giant tables with a lot of range patterns. The other candidate would be #146178 but I don't see anything that would be related in that benchmark.

Either way, together with the secondary benchmarks, all of those are tiny changes (0.002s) on tiny benchmarks, so I don't think this worth more investigation.

@rustbot label: +perf-regression-triaged

Qelxiros and others added 10 commits September 8, 2025 22:07

change end to last

8d0c07f

Update wasm-component-ld to 0.5.17

6e36750

Keeping this up-to-date as the project itself, and its dependencies, are updated.

don't trim paths in mir dumping when filtering and at the top of the …

90e74de

…file

Rollup merge of rust-lang#144765 - Qelxiros:range-inclusive-last, r=j…

d0ba5e3

…hpratt inclusive `Range`s: change `end` to `last` Tracking issue: rust-lang#125687 ACP: rust-lang/libs-team#511

Rollup merge of rust-lang#146378 - alexcrichton:update-wasm-component…

29cbf41

…-ld, r=lqd Update wasm-component-ld to 0.5.17 Keeping this up-to-date as the project itself, and its dependencies, are updated.

Rollup merge of rust-lang#146391 - beepster4096:trimnt, r=saethlin

212baec

Trim paths less in MIR dumping With this PR, the paths MIR dump filters and that are printed at the start of a dump file are no longer trimmed. They don't include the crate that is being compiled, however.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2025

bors merged commit 565a9ca into rust-lang:master Sep 10, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 10, 2025

rustbot added the perf-regression Performance regression. label Sep 10, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #146409

Rollup of 5 pull requests #146409

Uh oh!

matthiaskrgr commented Sep 10, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

rust-log-analyzer commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

matthiaskrgr commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 10, 2025

Uh oh!

panstromek commented Sep 15, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #146409

Rollup of 5 pull requests #146409

Uh oh!

Conversation

matthiaskrgr commented Sep 10, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

rust-log-analyzer commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

matthiaskrgr commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 10, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

panstromek commented Sep 15, 2025

Uh oh!

Uh oh!

matthiaskrgr commented Sep 10, 2025 •

edited by rustbot

Loading