Skip to content

Conversation

fmease
Copy link
Member

@fmease fmease commented Sep 12, 2025

Note

No need to conduct triage on this PR. This is just a personal playground for very early / rough perf experiments.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 12, 2025
@fmease

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[perf] rustdoc: Don't obtain early resolver unless `--generate-macro-expansion`
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 12, 2025
@rust-bors

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 12, 2025
@fmease fmease changed the title [perf] rustdoc: Don't obtain early resolver unless --generate-macro-expansion [perf] rustdoc Sep 12, 2025
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend labels Sep 13, 2025
@fmease

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 13, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2025
@rust-bors

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease force-pushed the rustdoc-gen-mac-exp-perf-fix branch from abca022 to b204031 Compare September 13, 2025 16:59
@fmease

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 13, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@rust-bors

This comment was marked as resolved.

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease changed the title [perf] rustdoc Perf experiments Sep 15, 2025
@fmease fmease removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend A-run-make Area: port run-make Makefiles to rmake.rs T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 15, 2025
@rust-lang rust-lang locked and limited conversation to collaborators Sep 25, 2025
@fmease fmease changed the title Perf experiments [DO NOT MERGE] Early perf experiments Sep 25, 2025
@fmease fmease force-pushed the rustdoc-gen-mac-exp-perf-fix branch from b204031 to ac3f32d Compare September 26, 2025 06:47
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 26, 2025
@fmease fmease changed the title [DO NOT MERGE] Early perf experiments [DO NOT MERGE OR REVIEW] Early perf experiments Sep 26, 2025
@rust-lang rust-lang unlocked this conversation Sep 26, 2025
@fmease
Copy link
Member Author

fmease commented Sep 26, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 26, 2025
[DO NOT MERGE OR REVIEW] Early perf experiments
@rust-bors

This comment has been minimized.

@rust-lang rust-lang deleted a comment from rust-timer Sep 26, 2025
@rust-lang rust-lang deleted a comment from rust-timer Sep 26, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 26, 2025

☀️ Try build successful (CI)
Build commit: a77816d (a77816d56c8fdadab64ae3f9fe1a653bfdb975a8, parent: 40ace17fc3891155bad26a50d60a9ab07b83bf8e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a77816d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results (secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.2% [2.9%, 5.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.524s -> 470.244s (-0.27%)
Artifact size: 388.09 MiB -> 388.11 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants