Skip to content

Constify Range functions #146573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

Constify Range functions #146573

merged 1 commit into from
Nov 3, 2025
+171 −90

Conversation

@Randl
Copy link
Contributor

@Randl Randl commented Sep 15, 2025

Constify various Range traits, functions, and implementations

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum
Mark-Simulacrum reviewed Sep 28, 2025
View reviewed changes
@rustbot

This comment has been minimized.

Sign in to view
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Randl
Copy link
Contributor Author

Randl commented Oct 21, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 2, 2025

📌 Commit 4ee19d9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#146573 - Randl:const-range, r=Mark-Simulacrum
06423e7 
Constify Range functions

Constify various `Range` traits, functions, and implementations
This was referenced Nov 2, 2025
Closed
Merged
bors added a commit that referenced this pull request Nov 2, 2025
@bors
Auto merge of #148412 - matthiaskrgr:rollup-59a302x, r=matthiaskrgr
c5dabe8 
Rollup of 7 pull requests

Successful merges:

 - #146573 (Constify Range functions)
 - #146699 (Add `is_ascii` function optimized for LoongArch64 for [u8])
 - #148026 (std: don't leak the thread closure if destroying the thread attributes fails)
 - #148135 (Ignore unix socket related tests for VxWorks)
 - #148211 (clippy fixes and code simplification)
 - #148395 (Generalize branch references)
 - #148405 (Fix suggestion when there were a colon already in generics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6621bbc into rust-lang:master Nov 3, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for #146573
867b37f 
Rollup merge of #146573 - Randl:const-range, r=Mark-Simulacrum

Constify Range functions

Constify various `Range` traits, functions, and implementations
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148412 - matthiaskrgr:rollup-59a302x, r=matthiaskrgr
3214048 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#146573 (Constify Range functions)
 - rust-lang/rust#146699 (Add `is_ascii` function optimized for LoongArch64 for [u8])
 - rust-lang/rust#148026 (std: don't leak the thread closure if destroying the thread attributes fails)
 - rust-lang/rust#148135 (Ignore unix socket related tests for VxWorks)
 - rust-lang/rust#148211 (clippy fixes and code simplification)
 - rust-lang/rust#148395 (Generalize branch references)
 - rust-lang/rust#148405 (Fix suggestion when there were a colon already in generics)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148412 - matthiaskrgr:rollup-59a302x, r=matthiaskrgr
d867ed0 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#146573 (Constify Range functions)
 - rust-lang/rust#146699 (Add `is_ascii` function optimized for LoongArch64 for [u8])
 - rust-lang/rust#148026 (std: don't leak the thread closure if destroying the thread attributes fails)
 - rust-lang/rust#148135 (Ignore unix socket related tests for VxWorks)
 - rust-lang/rust#148211 (clippy fixes and code simplification)
 - rust-lang/rust#148395 (Generalize branch references)
 - rust-lang/rust#148405 (Fix suggestion when there were a colon already in generics)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148412 - matthiaskrgr:rollup-59a302x, r=matthiaskrgr
deb7e87 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#146573 (Constify Range functions)
 - rust-lang/rust#146699 (Add `is_ascii` function optimized for LoongArch64 for [u8])
 - rust-lang/rust#148026 (std: don't leak the thread closure if destroying the thread attributes fails)
 - rust-lang/rust#148135 (Ignore unix socket related tests for VxWorks)
 - rust-lang/rust#148211 (clippy fixes and code simplification)
 - rust-lang/rust#148395 (Generalize branch references)
 - rust-lang/rust#148405 (Fix suggestion when there were a colon already in generics)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Randl @rustbot @Mark-Simulacrum @bors