Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 15, 2025

Fixes the test failure in #146545.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ p=10 (blocks #146545)

@bors
Copy link
Collaborator

bors commented Sep 15, 2025

📌 Commit dcc62e7 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2025
@bors
Copy link
Collaborator

bors commented Sep 15, 2025

⌛ Testing commit dcc62e7 with merge 5db35b6...

bors added a commit that referenced this pull request Sep 15, 2025
Only run Cranelift dist test on nightly

Fixes the test failure in #146545.

r? `@jieyouxu`
@bors
Copy link
Collaborator

bors commented Sep 15, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Sep 15, 2025

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2025
bors added a commit that referenced this pull request Sep 15, 2025
Only run Cranelift dist test on nightly

Fixes the test failure in #146545.

r? `@jieyouxu`
@bors
Copy link
Collaborator

bors commented Sep 15, 2025

⌛ Testing commit dcc62e7 with merge a0c541a...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jieyouxu
Copy link
Member

Error response from daemon: Get "https://ghcr.io/v2/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Please don't tell me there's an outage :O

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[WARNING] `tests/rustdoc-gui/search-result-display.goml` line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

======== tests/rustdoc-gui/setting-auto-hide-item-methods-docs.goml ========

`tests/rustdoc-gui/setting-auto-hide-item-methods-docs.goml` setting-auto-hide-item-methods-docs output:
Waiting failed: 30000ms exceeded
stack: TimeoutError: Waiting failed: 30000ms exceeded
    at new WaitTask (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/common/WaitTask.js:50:34)
    at IsolatedWorld.waitForFunction (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Realm.js:25:26)
    at CdpFrame.waitForFunction (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Frame.js:561:43)
    at CdpFrame.<anonymous> (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/util/decorators.js:98:27)
    at CdpPage.waitForFunction (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:1366:37)
    at runAllCommands (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:418:28)
    at async innerRunTestCode (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:696:21)
    at async innerRunTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:633:17)
    at async runTests (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:824:27)



<= doc-ui tests done: 141 succeeded, 1 failed, 0 filtered out

@bors
Copy link
Collaborator

bors commented Sep 15, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2025
@jieyouxu
Copy link
Member

Suspected flaky rustdoc-gui test.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2025
@bors
Copy link
Collaborator

bors commented Sep 15, 2025

⌛ Testing commit dcc62e7 with merge f3fd3ef...

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 15, 2025
@bors
Copy link
Collaborator

bors commented Sep 15, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing f3fd3ef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 15, 2025
@bors bors merged commit f3fd3ef into rust-lang:master Sep 15, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 15, 2025
bors added a commit that referenced this pull request Sep 15, 2025
[beta] Initial cut for 1.91 beta

https://forge.rust-lang.org/release/process.html#beta-pr

Also backports:

- Only run Cranelift dist test on nightly #146582

r? `@Mark-Simulacrum`
@Kobzol Kobzol deleted the cranelift-test-nightly branch September 15, 2025 15:36
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d1ed52b (parent) -> f3fd3ef (this PR)

Test differences

Show 3 test diffs

Stage 2

  • [ui] tests/ui/dist/cranelift-x86_64-unknown-linux-gnu-dist.rs: ignore (only executed when performing tests on dist toolchain) -> ignore (only executed when the release channel is nightly ((cranelift is not stable yet))) (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f3fd3efe4f698ad9dc2ccd6b46a3b07e1bc911da --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 8705.9s -> 6130.2s (-29.6%)
  2. aarch64-apple: 7260.9s -> 6040.8s (-16.8%)
  3. dist-aarch64-apple: 7007.3s -> 8056.8s (15.0%)
  4. x86_64-gnu-llvm-20-1: 3725.9s -> 3237.0s (-13.1%)
  5. i686-gnu-nopt-1: 8342.5s -> 7339.4s (-12.0%)
  6. x86_64-rust-for-linux: 3059.0s -> 2734.6s (-10.6%)
  7. aarch64-gnu-debug: 4377.8s -> 3922.7s (-10.4%)
  8. x86_64-gnu-llvm-19: 2812.8s -> 2523.8s (-10.3%)
  9. dist-x86_64-solaris: 5566.5s -> 6125.7s (10.0%)
  10. x86_64-gnu-debug: 7177.3s -> 6457.9s (-10.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f3fd3ef): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.6%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Cycles

Results (primary 2.7%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.872s -> 473.025s (-0.18%)
Artifact size: 390.16 MiB -> 390.15 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants