Cleanup FnDecl::inner_full_print
#146645
Merged
Cleanup FnDecl::inner_full_print
#146645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
reviewed
Sep 16, 2025
yotamofek
force-pushed
the
pr/rustdoc/fndecl_inner_full_print
branch
from
6a962cd to
90b964f
Compare
fmease
approved these changes
Sep 17, 2025
|
Thanks, that reads a lot better!
Personally speaking, I would be in favor. However, we have a bunch of other places in r=me with nit addressed @bors delegate+ |
|
✌️ @yotamofek, you can now approve this pull request! If @fmease told you to " |
yotamofek
force-pushed
the
pr/rustdoc/fndecl_inner_full_print
branch
from
90b964f to
1d8971c
Compare
bors
added
S-waiting-on-bors
|
@bors rollup |
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 18, 2025
…full_print, r=fmease Cleanup `FnDecl::inner_full_print` `inner_full_print` was pretty hard to follow IMHO. Hopefully this cleans it up a little bit. Also, it was checking whether `self.inputs` is empty twice, and then handling an unreachable match arm: https://github.com/yotamofek/rust/blob/f836ae4e663b6e8938096b8559e094d18361be55/src/librustdoc/html/format.rs#L1368C1-L1368C33 `last_input_index` could only be `None` if the fn has no parameters, in which case the loop body would never run. r? `@GuillaumeGomez` if you have the capacity :) BTW, can we rename `FnDecl::inputs` to `parameters` or something? And `output` to `return_ty`?
bors
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup of 5 pull requests Successful merges: - #146566 (Lint more overlapping assignments in MIR.) - #146645 (Cleanup `FnDecl::inner_full_print`) - #146664 (Clean up `ty::Dynamic`) - #146673 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4)) - #146694 (Remove ImplSubject) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup merge of #146645 - yotamofek:pr/rustdoc/fndecl_inner_full_print, r=fmease Cleanup `FnDecl::inner_full_print` `inner_full_print` was pretty hard to follow IMHO. Hopefully this cleans it up a little bit. Also, it was checking whether `self.inputs` is empty twice, and then handling an unreachable match arm: https://github.com/yotamofek/rust/blob/f836ae4e663b6e8938096b8559e094d18361be55/src/librustdoc/html/format.rs#L1368C1-L1368C33 `last_input_index` could only be `None` if the fn has no parameters, in which case the loop body would never run. r? ``@GuillaumeGomez`` if you have the capacity :) BTW, can we rename `FnDecl::inputs` to `parameters` or something? And `output` to `return_ty`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inner_full_printwas pretty hard to follow IMHO.Hopefully this cleans it up a little bit.
Also, it was checking whether
self.inputsis empty twice, and then handling an unreachable match arm:https://github.com/yotamofek/rust/blob/f836ae4e663b6e8938096b8559e094d18361be55/src/librustdoc/html/format.rs#L1368C1-L1368C33
last_input_indexcould only beNoneif the fn has no parameters, in which case the loop body would never run.r? @GuillaumeGomez if you have the capacity :)
BTW, can we rename
FnDecl::inputstoparametersor something? Andoutputtoreturn_ty?