Skip to content

add private module override re-export test #146806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2025
Merged

add private module override re-export test #146806

merged 4 commits into from
Sep 23, 2025

Conversation

el-ev
Copy link
Contributor

@el-ev el-ev commented Sep 20, 2025 •
edited by rustbot
Loading

Added a new test to check that rustdoc does not create links to m2 in the crate root when pub use m1::* is overrided by use crate::m1::m2.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lolbinarycat
lolbinarycat reviewed Sep 21, 2025
View reviewed changes
@el-ev el-ev requested a review from lolbinarycat September 22, 2025 03:48
lolbinarycat
lolbinarycat reviewed Sep 22, 2025
View reviewed changes
@lolbinarycat
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 22, 2025

📌 Commit bd98e73 has been approved by lolbinarycat

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#146806 - el-ev:issue60926, r=lolbinarycat
225e847 
add private module override re-export test

- Closes rust-lang#60926

Added a new test to check that `rustdoc` does not create links to `m2` in the crate root when `pub use m1::*` is overrided by `use crate::m1::m2`.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 22, 2025
Closed
bors added a commit that referenced this pull request Sep 22, 2025
@bors
Auto merge of #146910 - matthiaskrgr:rollup-n2qahqc, r=matthiaskrgr
d3d7317 
Rollup of 7 pull requests

Successful merges:

 - #146632 (Fix uses of "adaptor")
 - #146775 (fixes for numerous clippy warnings)
 - #146802 (mbe: Simplifications and refactoring)
 - #146806 (add private module override re-export test)
 - #146866 ([rustdoc] Correctly handle intra doc link when type alias disambiguator is passed for primitive)
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 23, 2025
@Zalathar
Rollup merge of rust-lang#146806 - el-ev:issue60926, r=lolbinarycat
c4f8027 
add private module override re-export test

- Closes rust-lang#60926

Added a new test to check that `rustdoc` does not create links to `m2` in the crate root when `pub use m1::*` is overrided by `use crate::m1::m2`.
@Zalathar Zalathar mentioned this pull request Sep 23, 2025
Closed
bors added a commit that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146916 - Zalathar:rollup-4o8s63n, r=Zalathar
a67c6f5 
Rollup of 13 pull requests

Successful merges:

 - #146632 (Fix uses of "adaptor")
 - #146731 (test: Use SVG for terminal url test)
 - #146775 (fixes for numerous clippy warnings)
 - #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
 - #146799 (Fix a dangling reference in `rustc_thread_pool`)
 - #146802 (mbe: Simplifications and refactoring)
 - #146806 (add private module override re-export test)
 - #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
 - #146875 (tests/run-make/crate-loading: Rename source files for clarity)
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146907 (add regression test for issue 146537)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2025
Merged
bors added a commit that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146938 - matthiaskrgr:rollup-y06ggfz, r=matthiaskrgr
975e6c8 
Rollup of 10 pull requests

Successful merges:

 - #146632 (Fix uses of "adaptor")
 - #146731 (test: Use SVG for terminal url test)
 - #146775 (fixes for numerous clippy warnings)
 - #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
 - #146799 (Fix a dangling reference in `rustc_thread_pool`)
 - #146802 (mbe: Simplifications and refactoring)
 - #146806 (add private module override re-export test)
 - #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
 - #146875 (tests/run-make/crate-loading: Rename source files for clarity)
 - #146877 (prevent line number from being copied in chrome)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d15233 into rust-lang:master Sep 23, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 23, 2025
rust-timer added a commit that referenced this pull request Sep 23, 2025
@rust-timer
Unrolled build for #146806
4854b41 
Rollup merge of #146806 - el-ev:issue60926, r=lolbinarycat

add private module override re-export test

- Closes #60926

Added a new test to check that `rustdoc` does not create links to `m2` in the crate root when `pub use m1::*` is overrided by `use crate::m1::m2`.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#146806 - el-ev:issue60926, r=lolbinarycat
0cbe830 
add private module override re-export test

- Closes rust-lang#60926

Added a new test to check that `rustdoc` does not create links to `m2` in the crate root when `pub use m1::*` is overrided by `use crate::m1::m2`.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@bors @Muscraft
Auto merge of rust-lang#146938 - matthiaskrgr:rollup-y06ggfz, r=matth…
bbd7d52 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#146632 (Fix uses of "adaptor")
 - rust-lang#146731 (test: Use SVG for terminal url test)
 - rust-lang#146775 (fixes for numerous clippy warnings)
 - rust-lang#146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
 - rust-lang#146799 (Fix a dangling reference in `rustc_thread_pool`)
 - rust-lang#146802 (mbe: Simplifications and refactoring)
 - rust-lang#146806 (add private module override re-export test)
 - rust-lang#146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
 - rust-lang#146875 (tests/run-make/crate-loading: Rename source files for clarity)
 - rust-lang#146877 (prevent line number from being copied in chrome)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolbinarycat lolbinarycat lolbinarycat left review comments

Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

rustdoc: private module appears when overriding glob re-export
5 participants
@el-ev @rustbot @lolbinarycat @bors @notriddle