Rollup of 9 pull requests #146879

Zalathar · 2025-09-22T10:25:18Z

Successful merges:

regression test for Cow<[u8]> layout #145411 (regression test for Cow<[u8]> layout)
std_detect on Darwin AArch64: update features #146397 (std_detect on Darwin AArch64: update features)
emit attribute for readonly non-pure inline assembly #146791 (emit attribute for readonly non-pure inline assembly)
Support ctr and lr as clobber-only registers in PowerPC inline assembly #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
Introduce "wrapper" helpers to rustdoc #146838 (Introduce "wrapper" helpers to rustdoc)
Add self-profile events for target-machine creation #146845 (Add self-profile events for target-machine creation)
btree InternalNode::new safety comments #146846 (btree InternalNode::new safety comments)
Make mips64el-unknown-linux-muslabi64 link dynamically #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
assert_unsafe_precondition: fix some incorrect check_language_ub #146878 (assert_unsafe_precondition: fix some incorrect check_language_ub)

r? @ghost
@rustbot modify labels: rollup

Now that this feature has a standard identifier, Darwin has started exposing it accordingly, in addition to the existing less-standard way. Check both, and enable the `crc` feature if either identifier for it is present to ensure backwards and forwards compatibility.

Brings the list of checkable features up to date with the initial release of macOS 26 "Tahoe".

These code paths are surprisingly hot in the `large-workspace` benchmark; it would be handy to see some detailed timings and execution counts.

I missed this target when I changed all the other tier 3 targets. Only realized that this one was still statically linked when I looked at the list of targets in the test later. Signed-off-by: Jens Reidel <[email protected]>

…ark-Simulacrum regression test for Cow<[u8]> layout requested by ralf in rust-lang#117763 (comment)

std_detect on Darwin AArch64: update features Synchronizes the list (and re-sorts it alphabetically by `FEAT` name) with the initial release version of macOS Tahoe.

…kic,joshtriplett emit attribute for readonly non-pure inline assembly fixes rust-lang#146761 Provide a better `MemoryEffects` to LLVM when an inline assembly block specifies `readonly` but not `pure`. That means that the assembly block may not perform any writes, but that there still may be side effects from its instructions. I haven't been able to find a case yet where this actually matters, though. So the test checks that the right attribute is applied, but the generated assembly is equivalent to not specifying `readonly` at all. r? ````@nikic```` cc ````@Amanieu````

Support ctr and lr as clobber-only registers in PowerPC inline assembly Follow-up to rust-lang#131341. CTR and LR are marked as volatile in all ABIs, but I skipped them in rust-lang#131341 due to they are currently marked as reserved. https://github.com/rust-lang/rust/blob/dd7fda570040e8a736f7d8bc28ddd1b444aabc82/compiler/rustc_target/src/asm/powerpc.rs#L209-L212 However, they are actually only unusable as input/output of inline assembly, and should be fine to support as clobber-only registers as discussed in [#t-compiler > ppc/ppc64 inline asm support](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/ppc.2Fppc64.20inline.20asm.20support/with/540413845). r? ````@Amanieu```` or ````@workingjubilee```` cc ````@programmerjake```` ````@rustbot```` label +O-PowerPC +A-inline-assembly

…olbinarycat Introduce "wrapper" helpers to rustdoc Add a few traits for streamlining places where we need to wrap certain `fmt::Display`s in stuff like parentheses or brackets. Hopefully this makes the actual display logic slightly easier to read. First two commits are small, unrelated cleanups. I'll probably add some doc comments to the stuff in `display.rs`, maybe also play around with the API, but wanted to get feedback on this idea first.

…bzol Add self-profile events for target-machine creation These code paths are surprisingly hot in the `large-workspace` benchmark (e.g. see perf changes from rust-lang#146700), suggesting room for more improvement. It would be handy to see some detailed timings and execution counts.

btree InternalNode::new safety comments

…=jieyouxu Make mips64el-unknown-linux-muslabi64 link dynamically I missed this target when I changed all the other tier 3 targets in rust-lang#144410. Only realized that this one was still statically linked when I looked at the list of targets in the test later (rust-lang#146588). since those two PRs were reviewed by you: r? ````@jieyouxu````

…ss35 assert_unsafe_precondition: fix some incorrect check_language_ub r? `@tgross35`

Zalathar · 2025-09-22T10:26:42Z

@bors r+ rollup=never p=5

bors · 2025-09-22T10:26:46Z

📌 Commit 8f80707 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-09-22T11:15:52Z

⌛ Testing commit 8f80707 with merge 29005cb...

bors · 2025-09-22T14:34:38Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 29005cb to master...

rust-timer · 2025-09-22T14:37:15Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#145411	regression test for Cow<[u8]> layout	`76459619873e758c7384d30a59445bf02b0ae66a` (link)
#146397	std_detect on Darwin AArch64: update features	`eddbb3b50b7bc6a67e0900d702c36147bf656f45` (link)
#146791	emit attribute for readonly non-pure inline assembly	`a3c8c3a8ef7ea16d3113d122929afc285068d339` (link)
#146831	Support ctr and lr as clobber-only registers in PowerPC inl…	`82b12401113a2d88cb94c36bb8684aa2558cd507` (link)
#146838	Introduce "wrapper" helpers to rustdoc	`429bbec29a1949e65cf8240ab282efef74f84a55` (link)
#146845	Add self-profile events for target-machine creation	`077b48fd34349ca34bcce5f0f10aa3042b9d7213` (link)
#146846	btree InternalNode::new safety comments	`860914428ba9d208dfad82d653b1de105afb5f4c` (link)
#146858	Make mips64el-unknown-linux-muslabi64 link dynamically	`2eb5085646aa5953c20021308782a1984867dfe5` (link)
#146878	assert_unsafe_precondition: fix some incorrect check_langua…	`04c094b852e62f171d1abeca31c3f54edaac2cd7` (link)

previous master: 9f32ccf35f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-22T14:37:52Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9f32ccf (parent) -> 29005cb (this PR)

Test differences

Show 11 test diffs

Stage 1

[codegen] tests/codegen-llvm/asm/readonly-not-pure.rs: [missing] -> pass (J1)
[codegen] tests/codegen-llvm/issues/cows-dont-have-branches-117763.rs: [missing] -> ignore (ignored when randomizing layouts) (J1)

Stage 2

[codegen] tests/codegen-llvm/issues/cows-dont-have-branches-117763.rs: [missing] -> ignore (ignored when randomizing layouts) (J0)
[codegen] tests/codegen-llvm/issues/cows-dont-have-branches-117763.rs: [missing] -> pass (J2)
[codegen] tests/codegen-llvm/asm/readonly-not-pure.rs: [missing] -> pass (J3)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 29005cb128e6d447e6bd9c110c9a684665f95985 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3792.5s -> 4603.7s (21.4%)
dist-aarch64-apple: 6275.7s -> 7386.9s (17.7%)
aarch64-apple: 5542.1s -> 6249.3s (12.8%)
i686-gnu-nopt-1: 8054.8s -> 7187.3s (-10.8%)
dist-aarch64-linux: 6714.0s -> 6066.1s (-9.6%)
x86_64-gnu-llvm-20-2: 6280.8s -> 5709.1s (-9.1%)
dist-aarch64-windows-gnullvm: 4666.9s -> 5069.9s (8.6%)
x86_64-mingw-1: 10270.0s -> 11146.0s (8.5%)
dist-x86_64-apple: 7280.9s -> 7871.4s (8.1%)
aarch64-msvc-2: 4602.4s -> 4937.3s (7.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-22T16:40:31Z

Finished benchmarking commit (29005cb): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	2
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	7
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	1

Max RSS (memory usage)

Results (primary 1.0%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	2
Regressions ❌ (secondary)	4.2%	[2.1%, 5.0%]	7
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.4%]	2
Improvements ✅ (secondary)	-1.8%	[-2.2%, -1.0%]	3
All ❌✅ (primary)	1.0%	[-0.8%, 2.6%]	4

Cycles

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-4.3%, -2.5%]	3
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 471.273s -> 472.389s (0.24%)
Artifact size: 387.92 MiB -> 389.97 MiB (0.53%)

Kobzol · 2025-09-23T12:22:38Z

The changes here seem very similar to changes from other rollups in the past week, just in the opposite direction. So I think that it is noise (even though the changes here are mostly improvements anyway).

@rustbot label: +perf-regression-triaged

Rollup of 9 pull requests Successful merges: - rust-lang#145411 (regression test for Cow<[u8]> layout) - rust-lang#146397 (std_detect on Darwin AArch64: update features) - rust-lang#146791 (emit attribute for readonly non-pure inline assembly) - rust-lang#146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly) - rust-lang#146838 (Introduce "wrapper" helpers to rustdoc) - rust-lang#146845 (Add self-profile events for target-machine creation) - rust-lang#146846 (btree InternalNode::new safety comments) - rust-lang#146858 (Make mips64el-unknown-linux-muslabi64 link dynamically) - rust-lang#146878 (assert_unsafe_precondition: fix some incorrect check_language_ub) r? `@ghost` `@rustbot` modify labels: rollup

pthariensflame and others added 22 commits September 13, 2025 23:25

std_detect Darwin AArch64: re-alphabetize

edc87e3

std_detect Darwin AArch64: synchronize features

d49f6a7

Brings the list of checkable features up to date with the initial release of macOS 26 "Tahoe".

Support ctr and lr as clobber-only registers in PowerPC inline assembly

f4b8768

Add self-profile events for target-machine creation

b17fb70

These code paths are surprisingly hot in the `large-workspace` benchmark; it would be handy to see some detailed timings and execution counts.

btree InternalNode::new safety comments

2dfcd09

regression test for rust-lang#117763

5f0a68e

Make mips64el-unknown-linux-muslabi64 link dynamically

b3c2435

I missed this target when I changed all the other tier 3 targets. Only realized that this one was still statically linked when I looked at the list of targets in the test later. Signed-off-by: Jens Reidel <[email protected]>

emit attribute for readonly non-pure inline assembly

3565b06

Early return in visibility_print_with_space

c54a953

Re-use some existing util fns

cdf9661

Introduce "wrapper" helpers to rustdoc

2067160

assert_unsafe_precondition: fix some incorrect check_language_ub

7d00129

Rollup merge of rust-lang#145411 - the8472:cows-have-no-branches, r=M…

8c0c537

…ark-Simulacrum regression test for Cow<[u8]> layout requested by ralf in rust-lang#117763 (comment)

Rollup merge of rust-lang#146397 - pthariensflame:patch-1, r=Amanieu

d144638

std_detect on Darwin AArch64: update features Synchronizes the list (and re-sorts it alphabetically by `FEAT` name) with the initial release version of macOS Tahoe.

Rollup merge of rust-lang#146846 - hkBst:btree-2, r=tgross35

8cf94b6

btree InternalNode::new safety comments

Rollup merge of rust-lang#146878 - RalfJung:check_language_ub, r=tgro…

8f80707

…ss35 assert_unsafe_precondition: fix some incorrect check_language_ub r? `@tgross35`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2025

bors merged commit 29005cb into rust-lang:master Sep 22, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 22, 2025

This was referenced Sep 22, 2025

rustdoc: make #[doc(hidden)] render the same as other attrs #145818

Draft

(EXPERIMENT) Perf experiments for target-machine command-line quoting #146804

Closed

rustbot added the perf-regression Performance regression. label Sep 22, 2025

Zalathar deleted the rollup-vm97j8b branch September 22, 2025 21:11

rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #146879

Rollup of 9 pull requests #146879

Uh oh!

Zalathar commented Sep 22, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 22, 2025

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #146879

Rollup of 9 pull requests #146879

Uh oh!

Conversation

Zalathar commented Sep 22, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 22, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Uh oh!

Zalathar commented Sep 22, 2025 •

edited by rustbot

Loading