Emit error when using path-segment keyword as cfg pred

[mu001999]

Fixes #146968

Emit error CfgPredicateIdentifier if the word is path-segment keyword.

r? petrochenkov

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

[petrochenkov]

Could you

• add similar test cases for some non path-segment keyword, like struct
• add test cases for --cfg on command line and make sure that they behave identically to cfg! and #[cfg].

After that we should be able to run crater on this.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[mu001999]

add test cases for --cfg on command line and make sure that they behave identically to cfg! and #[cfg]

--cfg will emit same error but will be suppressed because parse_cfg is called with ParseSess::with_fatal_emitter

[mu001999]

@rustbot ready

[petrochenkov]

add test cases for --cfg on command line and make sure that they behave identically to cfg! and #[cfg]

--cfg will emit same error but will be suppressed because parse_cfg is called with ParseSess::with_fatal_emitter

with_fatal_emitter doesn't suppress errors, it makes them fatal.
--cfg parsing has its own error reporting logic in fn parse_cfg in compiler\rustc_interface\src\interface.rs, and the new errors are not emitted there.
@rustbot author

[mu001999]

with_fatal_emitter doesn't suppress errors, it makes them fatal.

@petrochenkov I found with_fatal_emitter create dcx with FatalOnlyEmitter, see

rust/compiler/rustc_session/src/parse.rs

Lines 318 to 329 in a2db928

	pub fn with_fatal_emitter(locale_resources: Vec<&'static str>, fatal_note: String) -> Self {
	let translator = Translator::with_fallback_bundle(locale_resources, false);
	let sm = Arc::new(SourceMap::new(FilePathMapping::empty()));
	let fatal_emitter =
	Box::new(HumanEmitter::new(stderr_destination(ColorConfig::Auto), translator));
	let dcx = DiagCtxt::new(Box::new(FatalOnlyEmitter {
	fatal_emitter,
	fatal_note: Some(fatal_note),
	}))
	.disable_warnings();
	ParseSess::with_dcx(dcx, sm)
	}

and the comment of FatalOnlyEmitter and the impl of FatalOnlyEmitter::emit_diagnostic show only errors with diag.level == Level::Fatal can be emitted, see

rust/compiler/rustc_errors/src/emitter.rs

Lines 537 to 562 in 8155734

	/// An emitter that does nothing when emitting a non-fatal diagnostic.
	/// Fatal diagnostics are forwarded to `fatal_emitter` to avoid silent
	/// failures of rustc, as witnessed e.g. in issue #89358.
	pub struct FatalOnlyEmitter {
	pub fatal_emitter: Box<dyn Emitter + DynSend>,
	pub fatal_note: Option<String>,
	}
	impl Emitter for FatalOnlyEmitter {
	fn source_map(&self) -> Option<&SourceMap> {
	None
	}
	fn emit_diagnostic(&mut self, mut diag: DiagInner, registry: &Registry) {
	if diag.level == Level::Fatal {
	if let Some(fatal_note) = &self.fatal_note {
	diag.sub(Level::Note, fatal_note.clone(), MultiSpan::new());
	}
	self.fatal_emitter.emit_diagnostic(diag, registry);
	}
	}
	fn translator(&self) -> &Translator {
	self.fatal_emitter.translator()
	}
	}

[mu001999]

I have debug the logic in fn parse_cfg, and the err.emit is called in fact, but it is suppressed by the FatalOnlyEmitter.

[petrochenkov]

Ah, ok, "fatal emitter" means "fatal-only emitter".

In any case, the behavior is not correct.
I guess the assumption when using the fatal emitter was that we always reach the "expected key or key="value"" error at the bottom anyway, but that's not actually the case.
If we get to return (ident.name, meta_item.value_str()), then all the non-fatal errors are lost, which is incorrect.

[mu001999]

@rustbot ready

[samueltardieu]

It looks like you removed some .32bit.stderr files from src/tools/clippy/tests/ui/ instead of renaming them.

[mu001999]

It looks like you removed some .32bit.stderr files from src/tools/clippy/tests/ui/ instead of renaming them.

Good catch! Recovered. Seems the 32bit revision is not tested on both my device and CI 🤔

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[petrochenkov]

Thanks, this should be ready for crater now, the remaining minor cleanups can be done later.
@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 4e55a50 (4e55a504843955c97eb06907c71f6f3e99208021, parent: 4068bafedd8ba724e332a5221c06a6fa531a30d2)

[petrochenkov]

@craterbot check

[craterbot]

👌 Experiment pr-146978 created and queued.
🤖 Automatically detected try build 4e55a50
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-146978 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more