Skip to content

Revert "Auto merge of #144086 - clubby789:alloc-zeroed, r=nikic" #147030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

Revert "Auto merge of #144086 - clubby789:alloc-zeroed, r=nikic" #147030

merged 1 commit into from
Sep 27, 2025
+0 −36

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Sep 25, 2025

This reverts commit 040a98a, reversing changes made to e8a792d.

This reverts #144086 on beta due to #145995. On master the issue will be fixed by #146766.

@nikic
Revert "Auto merge of rust-lang#144086 - clubby789:alloc-zeroed, r=ni…
186d91d 
…kic"

This reverts commit 040a98a, reversing
changes made to e8a792d.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@nikic nikic mentioned this pull request Sep 25, 2025
Merged
@wesleywiser
Copy link
Member

Discussed in the compiler team triage meeting as the path we want to take to resolve #145995 which has slipped to beta.

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 25, 2025

📌 Commit 186d91d has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 25, 2025
Closed
@matthiaskrgr
Copy link
Member

@bors rollup=never

@jieyouxu
Copy link
Member

@bors p=5 (beta revert)

bors added a commit that referenced this pull request Sep 27, 2025
@bors
Auto merge of #147030 - nikic:revert-alloc-zeroed, r=wesleywiser
73d5760 
Revert "Auto merge of #144086 - clubby789:alloc-zeroed, r=nikic"

This reverts commit 040a98a, reversing changes made to e8a792d.

This reverts #144086 on beta due to #145995. On master the issue will be fixed by #146766.
@bors
Copy link
Collaborator

bors commented Sep 27, 2025

⌛ Testing commit 186d91d with merge 73d5760...

@bors
Copy link
Collaborator

bors commented Sep 27, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2025
@Zalathar
Copy link
Contributor

@bors retry (runner flaked out)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2025
@bors
Copy link
Collaborator

bors commented Sep 27, 2025

⌛ Testing commit 186d91d with merge aa7859c...

@bors
Copy link
Collaborator

bors commented Sep 27, 2025

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing aa7859c to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2025
@bors bors merged commit aa7859c into rust-lang:beta Sep 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@davidtwco davidtwco

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
8 participants
@nikic @rustbot @wesleywiser @bors @matthiaskrgr @jieyouxu @Zalathar @davidtwco