Fix some crash-test directives #147122
Merged
Fix some crash-test directives #147122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR changes a file inside |
rustbot
added
S-waiting-on-review
|
@bors try jobs=aarch64-apple,aarch64-msvc-1,test-various,i686-gnu-1,i686-msvc-1 |
rust-bors bot
added a commit
that referenced
this pull request
Sep 28, 2025
Fix some crash-test directives try-job: aarch64-apple try-job: aarch64-msvc-1 try-job: test-various try-job: i686-gnu-1 try-job: i686-msvc-1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for c5ca529 failed: CI. Failed jobs:
|
Zalathar
force-pushed
the
crash-directives
branch
from
6ae0d38 to
d3608cf
Compare
|
@bors try jobs=aarch64-msvc-1,test-various,i686-gnu-1,i686-msvc-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 28, 2025
Fix some crash-test directives try-job: aarch64-msvc-1 try-job: test-various try-job: i686-gnu-1 try-job: i686-msvc-1
|
r=me once you're convinced by CI |
Zalathar
force-pushed
the
crash-directives
branch
from
d3608cf to
b71c469
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup of 7 pull requests Successful merges: - #133477 (Detect tuple structs that are unconstructable due to re-export) - #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool) - #146979 (constify Default on Nanoseconds) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147112 (all 48 keywords in just 300 characters) - #147122 (Fix some crash-test directives) - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup merge of #147122 - Zalathar:crash-directives, r=cjgillot Fix some crash-test directives - 120175 fails to crash for non-ELF targets; presumably this wasn't noticed because the CI jobs don't enable rustc assertions for non-ELF hosts. - 34127, 125722, and 131292 have `only-x86_64`, which is overly specific. - Unnecessary x86 directives cause friction for contributors using aarch64, especially now that many PR CI jobs also use aarch64. r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only-x86_64, which is overly specific.r? ghost