Port all viable contracts from verify-rust-std #147148
Draft
+1,684
−676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports over all contracts (other than those for `Alignment`, see the separate PR) that can be expressed using the current, experimental contracts syntax. (Notably, this excludes all contracts that refer to pointer validity.)
Updated via `./x.py test mir-opt --bless --stage 1`.
rustbot
added
S-waiting-on-author
Noratrieb
reviewed
Sep 29, 2025
| } | ||
|
|
||
| #[inline] | ||
| #[allow(unused_parens)] |
There was a problem hiding this comment.
(I know it's a draft so feel free to ignore, but I'd really prefer to see that lint bug being fixed first before merging so we don't have add all the allow)
There was a problem hiding this comment.
I believe this is fixed as part of #144438. Not sure exactly what caused the issue in the first place.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bjorn3
reviewed
Sep 30, 2025
| #[core::contracts::requires(!self.overflowing_mul(rhs).1)] | ||
| pub const unsafe fn unchecked_mul(self, rhs: Self) -> Self { | ||
| assert_unsafe_precondition!( | ||
| check_language_ub, |
There was a problem hiding this comment.
Many contracts are duplicating existing assert_unsafe_precondition!(). How should we handle this duplication?
bjorn3
reviewed
Sep 30, 2025
| + _7 = &_4; | ||
| + _6 = {closure@$SRC_DIR/core/src/num/uint_macros.rs:LL:COL} { 0: copy _7 }; | ||
| + StorageDead(_7); | ||
| + _5 = contract_check_requires::<{closure@core::num::<impl u16>::unchecked_shl::{closure#0}}>(move _6) -> [return: bb1, unwind continue]; |
There was a problem hiding this comment.
All these extra checks would slow down debug builds a lot in terms of runtime performance and likely a bit in build times, right? Can we check by how much exactly?
|
☔ The latest upstream changes (presumably #142771) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over all contracts (other than those for
Alignment, see the separate PR) that can be expressed using the current, experimental contracts syntax. (Notably, this excludes all contracts that refer to pointer validity.)