Refactor DropGuard with one ManuallyDrop #147238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Contributor
|
I'm a bit behind on my reviews, |
camsteffen
force-pushed
the
refactor-drop-guard
branch
from
b397f2e to
fff1d8d
Compare
camsteffen
commented
Oct 1, 2025
camsteffen
force-pushed
the
refactor-drop-guard
branch
from
fff1d8d to
2a1c764
Compare
joboet
reviewed
Oct 2, 2025
Comment on lines
-89
to
-90
| // First we ensure that dropping the guard will not trigger | ||
| // its destructor |
Member
There was a problem hiding this comment.
This comment seems valuable, I wouldn't remove it.
Contributor
Author
|
Okay, I'll close this. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Group the fields into a single ManuallyDrop with an inner struct. This simplifies/reduces the unsafe code.