Rollup of 6 pull requests #147282

Zalathar · 2025-10-02T23:16:30Z

Successful merges:

make rust-analyzer use a dedicated build directory #141839 (make rust-analyzer use a dedicated build directory)
Implement range support in //@ edition #146166 (Implement range support in //@ edition)
cg_llvm: Use helper methods for all calls to LLVMMDNodeInContext2 #147259 (cg_llvm: Use helper methods for all calls to LLVMMDNodeInContext2)
Disable triagebot auto stable-regression compiler backport nominations pending redesign #147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign)
add arm-maintainers to various targets #147268 (add arm-maintainers to various targets)
Move doc_cfg-specific code into cfg.rs #147270 (Move doc_cfg-specific code into cfg.rs)

r? @ghost
@rustbot modify labels: rollup

This avoids rust-analyzer having to wait for a build lock due to ./x running other commands (and the other way around).

No prejudice against re-enabling them if the nominations include a bit more context on _why_ it's automatically nominated and _which_ regression(s) are being addressed. Or as proposed, it could also simply become a reminder-to-nominate _comment_.

…lacrum,fee1-dead make rust-analyzer use a dedicated build directory inspired by rust-lang#132794

…mease,jieyouxu Implement range support in `//@ edition` First step to solve rust-lang#145364

…rcote cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2` Originally I was only planning on extracting an `md_node_in_context` method, but then I noticed that all callers of `LLVMMDNodeInContext2` could be covered by a small number of additional helper methods. There should be no change in compiler output.

…inations, r=apiraino,Urgau Disable triagebot auto stable-regression compiler backport nominations pending redesign Current auto compiler stable-regression backport nominations seem to be too aggressive, and seems to unfortunately lower signal-to-noise ratio of the compiler backport channel. So this PR disables the triagebot compiler auto stable-regression backport nominations pending a redesign. Beta-regression auto backport nominations are not modified, we might want to gather some more experience with it. No prejudice against re-enabling them if the nominations include a bit more context on _why_ it's automatically nominated and _which_ regression(s) are being addressed. Or as proposed, it could also simply become a reminder-to-nominate _comment_. cf. [#t-compiler/backports > rust-lang#146919: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23146919.3A.20stable-nominated/near/540979327) > I like the idea of rustbot just posting a message that suggests adding the label. That seems like a good compromise between avoiding forgotten nominations and avoiding spurious nominations. In any case, this was very much worth experimenting! r? `@apiraino` (or triagebot)

…argets, r=lqd add arm-maintainers to various targets Add the ``@rust-lang/arm-maintainers`` team as maintainers to the following targets: - `aarch64-unknown-linux-gnu` - `aarch64-unknown-none`/`aarch64-unknown-none-softfloat` - `aarch64-unknown-uefi` - `armv7-unknown-linux-gnueabi`/`armv7-unknown-linux-gnueabihf` - `armv7a-none-eabi`/`armv7a-none-eabihf` - `armv7r-none-eabi`/`armv7r-none-abihf` - `armv8r-none-eabihf` - `thumbv7em-none-eabi`/`thumbv7em-none-eabihf` - `thumbv7m-none-eabi` - `thumbv8m.base-none-eabi` - `thumbv8m.main-none-eabi`/`thumbv8m.main-none-eabihf` cc `@thejpster`

…lbinarycat Move doc_cfg-specific code into `cfg.rs` Follow-up of rust-lang#138907. r? lolbinarycat

Zalathar · 2025-10-02T23:16:43Z

@bors r+ rollup=never p=5

bors · 2025-10-02T23:16:46Z

📌 Commit 9e1b24d has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-03T00:49:25Z

⌛ Testing commit 9e1b24d with merge 3b8665c...

bors · 2025-10-03T03:53:28Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 3b8665c to master...

rust-timer · 2025-10-03T03:55:14Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141839	make rust-analyzer use a dedicated build directory	`34090422c92c236f4094e2425bc365bc9bfe8ac9` (link)
#146166	Implement range support in `//@ edition`	`4c6d6be064e78be4a0dd55da30e920b3ca00336b` (link)
#147259	cg_llvm: Use helper methods for all calls to `LLVMMDNodeInC…	`e1a62e95498a964f80b7f9bb7d6209c9afb22322` (link)
#147263	Disable triagebot auto stable-regression compiler backport …	`615d57dbac368749cb37a5cb305079102f48405c` (link)
#147268	add arm-maintainers to various targets	`8fb15f009fb6b0ecffddc9266b5b1af09a72b048` (link)
#147270	Move doc_cfg-specific code into `cfg.rs`	`1e27bffa988cacba4fbc78f69acdf3d78d6a3e4e` (link)

previous master: 8d603ef287

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-03T03:58:30Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d603ef (parent) -> 3b8665c (this PR)

Test differences

Show 14 test diffs

Stage 0

directives::tests::test_edition_range_edition_to_test: [missing] -> pass (J0)
directives::tests::test_parse_edition_range: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_double_dots: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_empty: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_empty_range: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_invalid_edition: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_inverted_range: [missing] -> pass (J0)
directives::tests::test_parse_edition_range_inverted_range_future: [missing] -> pass (J0)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: pr-check-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3b8665c5ab3aeced9b01672404c3764583e722ca --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3080.5s -> 4195.7s (36.2%)
x86_64-gnu: 6698.7s -> 7750.3s (15.7%)
x86_64-gnu-miri: 4099.6s -> 4651.5s (13.5%)
dist-i686-msvc: 9085.6s -> 7897.2s (-13.1%)
pr-check-1: 1571.7s -> 1376.0s (-12.4%)
aarch64-gnu-llvm-20-1: 3343.9s -> 3720.6s (11.3%)
i686-msvc-2: 8346.8s -> 7534.0s (-9.7%)
x86_64-gnu-llvm-20-1: 3311.5s -> 3631.2s (9.7%)
i686-gnu-nopt-1: 7355.2s -> 8047.5s (9.4%)
aarch64-apple: 7500.9s -> 8203.7s (9.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-03T05:03:52Z

Finished benchmarking commit (3b8665c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Max RSS (memory usage)

Results (primary -1.6%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	-1.6%	[-1.6%, -1.6%]	1

Cycles

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.119s -> 472.69s (0.12%)
Artifact size: 387.77 MiB -> 387.73 MiB (-0.01%)

tshepang and others added 16 commits September 22, 2025 21:02

make rust-analyzer settings use dedicated directory

24144ff

This avoids rust-analyzer having to wait for a build lock due to ./x running other commands (and the other way around).

Extract helper method set_metadata_node

ecb831d

Extract helper method module_add_named_metadata_node

ffeed2b

Extract helper method global_add_metadata_node

6a58f80

Extract helper method global_set_metadata_node

8ef9821

Move doc_cfg-specific code into cfg.rs

6275a19

add arm-maintainers to various targets

7715c0d

implement range support in //@ edition

c61ec94

Document range syntax on the rustc dev guide

6631c8e

Rollup merge of rust-lang#141839 - tshepang:ease-lsp-use, r=Mark-Simu…

a3291ed

…lacrum,fee1-dead make rust-analyzer use a dedicated build directory inspired by rust-lang#132794

Rollup merge of rust-lang#146166 - ferrocene:pvdrz/edition-range, r=f…

6fe05b5

…mease,jieyouxu Implement range support in `//@ edition` First step to solve rust-lang#145364

Rollup merge of rust-lang#147270 - GuillaumeGomez:move-cfg-code, r=lo…

9e1b24d

…lbinarycat Move doc_cfg-specific code into `cfg.rs` Follow-up of rust-lang#138907. r? lolbinarycat

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 3, 2025

bors merged commit 3b8665c into rust-lang:master Oct 3, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 3, 2025

Zalathar deleted the rollup-7wz3k9r branch October 3, 2025 04:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #147282

Rollup of 6 pull requests #147282

Uh oh!

Zalathar commented Oct 2, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

bors commented Oct 2, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Stage 0

Uh oh!

rust-timer commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Rollup of 6 pull requests #147282

Rollup of 6 pull requests #147282

Uh oh!

Conversation

Zalathar commented Oct 2, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 2, 2025

Uh oh!

bors commented Oct 2, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Test differences

Stage 0

Job duration changes

Uh oh!

rust-timer commented Oct 3, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zalathar commented Oct 2, 2025 •

edited by rustbot

Loading