Skip to content

Avoid LocalCopy instantiation for #[inline] on -Copt-level=0 #147351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Draft

Avoid LocalCopy instantiation for #[inline] on -Copt-level=0 #147351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/rustc_mir_transform/src/cross_crate_inline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ fn cross_crate_inlinable(tcx: TyCtxt<'_>, def_id: LocalDefId) -> bool {
// #[inline(never)] to force code generation.
match codegen_fn_attrs.inline {
InlineAttr::Never => return false,
InlineAttr::Hint | InlineAttr::Always | InlineAttr::Force { .. } => return true,
// For -Copt-level=0, we won't inline functions anyways, so there's no reason to codegen them as LocalCopy.
InlineAttr::Hint if tcx.sess.opts.optimize != OptLevel::No => return true,
InlineAttr::Always | InlineAttr::Force { .. } => return true,
_ => {}
}

Expand Down
Loading