some more proc_macro cleanups
#147386
Merged
some more proc_macro cleanups
#147386
+11
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @petrochenkov. Use |
|
The second commit makes sense to me, the arena's use is limited, and if the |
petrochenkov
reviewed
Oct 6, 2025
petrochenkov
added
S-waiting-on-author
cyrgani
force-pushed
the
proc-macro-cleanup-2
branch
from
df4d26e to
7aa52ea
Compare
cyrgani
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 8, 2025
Rollup of 6 pull requests Successful merges: - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error)) - #147386 (some more `proc_macro` cleanups) - #147412 (Convert impossible cases in macro resolution into assertions) - #147464 (prefer repeat_n() over repeat().take()) - #147469 (Add rustdoc crate name in error) - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several smaller cleanups to
proc_macro. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.Followup to #147166.