Rollup of 6 pull requests #147475

matthiaskrgr · 2025-10-08T13:39:29Z

Successful merges:

clarify wording of match ergonomics diagnostics (rust_2024_incompatible_pat lint and error) #144006 (clarify wording of match ergonomics diagnostics (rust_2024_incompatible_pat lint and error))
some more proc_macro cleanups #147386 (some more proc_macro cleanups)
Convert impossible cases in macro resolution into assertions #147412 (Convert impossible cases in macro resolution into assertions)
prefer repeat_n() over repeat().take() #147464 (prefer repeat_n() over repeat().take())
Add rustdoc crate name in error #147469 (Add rustdoc crate name in error)
refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions #147472 (refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions)

r? @ghost
@rustbot modify labels: rollup

…ions

…Nadrieril clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error) Partially addresses rust-lang#143557: - Uses different wording than the Edition Guide chapter, to hopefully stand alone a bit better. Instead of referring to the "default binding mode", it now talks about what can't be written "within elided reference patterns". I ended up going with "elided" instead of "implicit" in hope that it reads bit less like it should behave the same as an explicit reference pattern, but I'm not totally happy with that wording. - The explanatory note still points to where the default binding mode was introduced, but only refers to its effect, not what we call it. How that relates to the rest of the diagnostic may still be a bit of a puzzle, but hopefully it isn't too much of one? It also doesn't make sense anymore for the case of `&` written under a by-ref binding mode, so I've left the note out in that case (but kept the label). It's more cramped, but talking about binding modes would feel like a non-sequitur for the error about `&` patterns without further explanation. - Links to the stable version of the Edition Guide instead of the nightly version. It looks like almost every link to the Edition Guide in diagnostics is to the nightly version, presumably for the same reason as here: the diagnostics were added before the new Edition was stabilized, then never updated. I'll make a separate PR to clean up the others. This only changes the diagnostic messages, not the code suggestion or the Edition Guide. r? `@Nadrieril` or reassign

…trochenkov some more `proc_macro` cleanups Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not. Followup to rust-lang#147166.

…ochenkov Convert impossible cases in macro resolution into assertions associated discussion with `@petrochenkov:` [#t-compiler/help > understanding early name resolution of imports @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/understanding.20early.20name.20resolution.20of.20imports/near/542936677)

prefer repeat_n() over repeat().take()

…ge, r=GuillaumeGomez Add rustdoc crate name in error Fixes rust-lang#147458 I'm not entirely sure if what I am doing with the span is correct

…nikic refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions This simplifies the code and reduces the burden of maintaining our own wrappers. Work towards rust-lang#46437

matthiaskrgr · 2025-10-08T13:39:49Z

@bors r+ rollup=never p=5

bors · 2025-10-08T13:39:51Z

📌 Commit 359bfa9 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-10-08T16:07:11Z

⌛ Testing commit 359bfa9 with merge 7a52736...

bors · 2025-10-08T19:22:18Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7a52736 to master...

rust-timer · 2025-10-08T19:24:04Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144006	clarify wording of match ergonomics diagnostics (`rust_2024…	`6d9cbb5b292e2d49ceaac7bc0dbd31bd731e1591` (link)
#147386	some more `proc_macro` cleanups	`5f946f3816a3a900d32f9c0dcd232f163797a1ad` (link)
#147412	Convert impossible cases in macro resolution into assertions	`6f0838cd366c2106d7af0e67e9a90c939c2422be` (link)
#147464	prefer repeat_n() over repeat().take()	`b33f5e95214bffdcba0930ff7c81a4ac78841bd2` (link)
#147469	Add rustdoc crate name in error	`e22d9ea1b7e2e7ad090c3d823bb87646f51df7e5` (link)
#147472	refactor: replace `LLVMRustAtomicLoad/Store` with LLVM buil…	`41632e3b37a47804e1daf803721f86725e140355` (link)

previous master: 910617d84d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-08T19:25:49Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 910617d (parent) -> 7a52736 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7a52736039856a3626eefec32d80c9df900b7afd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-android: 1127.6s -> 1565.3s (38.8%)
aarch64-gnu-debug: 3657.7s -> 4273.9s (16.8%)
i686-gnu-nopt-1: 7272.0s -> 8143.2s (12.0%)
dist-ohos-aarch64: 4925.3s -> 4337.5s (-11.9%)
x86_64-rust-for-linux: 2603.5s -> 2912.7s (11.9%)
aarch64-gnu-llvm-20-1: 3339.0s -> 3688.3s (10.5%)
x86_64-gnu-aux: 6556.3s -> 7161.3s (9.2%)
x86_64-gnu-stable: 7109.3s -> 7762.7s (9.2%)
armhf-gnu: 4864.7s -> 5311.2s (9.2%)
aarch64-msvc-2: 5102.3s -> 4669.5s (-8.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-08T21:05:43Z

Finished benchmarking commit (7a52736): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-2.1%, 2.1%]	2

Cycles

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.8%, -2.6%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.206s -> 472.232s (-0.21%)
Artifact size: 388.42 MiB -> 388.41 MiB (-0.00%)

cyrgani and others added 14 commits October 5, 2025 23:25

remove unneeded imports

0a6462b

refactor confusing loop in proc_macro arena

74ec42e

remove Decode trait and only impl

7aa52ea

Convert impossible cases in macro resolution into assertions

6920a8e

prefer repeat_n() over repeat().take()

70a357a

clarify wording of match ergonomics diagnostics

ec99e3e

Improve missing create level error message

2c1e796

refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in funct…

1aed495

…ions

Rollup merge of rust-lang#147386 - cyrgani:proc-macro-cleanup-2, r=pe…

5c13022

…trochenkov some more `proc_macro` cleanups Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not. Followup to rust-lang#147166.

Rollup merge of rust-lang#147464 - RalfJung:repeat, r=saethlin

795bbaa

prefer repeat_n() over repeat().take()

Rollup merge of rust-lang#147469 - Jamesbarford:fix/crate-error-messa…

f6caa5f

…ge, r=GuillaumeGomez Add rustdoc crate name in error Fixes rust-lang#147458 I'm not entirely sure if what I am doing with the span is correct

Rollup merge of rust-lang#147472 - AMS21:remove_llvm_rust_atomics, r=…

359bfa9

…nikic refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions This simplifies the code and reduces the burden of maintaining our own wrappers. Work towards rust-lang#46437

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2025

bors merged commit 7a52736 into rust-lang:master Oct 8, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #147475

Rollup of 6 pull requests #147475

matthiaskrgr commented Oct 8, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

rust-timer commented Oct 8, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #147475

Rollup of 6 pull requests #147475

Conversation

matthiaskrgr commented Oct 8, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Oct 8, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Oct 8, 2025 •

edited by rustbot

Loading