allocator_kind and related queries converted to hooks

[azhogin]

'allocator_kind' and related queries converted to hooks to measure performance optimization.

[Kobzol]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: b26819f (b26819fc29ec19b685f8ba54ceac59c9d83e2039, parent: 828c2a9afccf3b3ff8133368cfbc8bfe526aaa4d)

[azhogin]

r? @petrochenkov

[azhogin]

@rustbot ready

[rust-timer]

Finished benchmarking commit (b26819f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Max RSS (memory usage)

Results (primary -2.8%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	2.6%	[1.8%, 4.9%]	6
Improvements ✅ (primary)	-4.6%	[-6.6%, -2.5%]	2
Improvements ✅ (secondary)	-1.2%	[-1.6%, -0.7%]	2
All ❌✅ (primary)	-2.8%	[-6.6%, 0.9%]	3

Cycles

Results (primary 2.1%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	3.5%	[2.3%, 5.6%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.991s -> 471.781s (0.38%)
Artifact size: 388.38 MiB -> 388.36 MiB (-0.01%)

[petrochenkov]

Suggested change

	c.get_crate_data(krate).cdata
	c.get_crate_data(krate).cdata.root.has_alloc_error_handler

No need to create CrateMetadataRef below.

[petrochenkov]

Suggested change

	c.get_crate_data(krate).cdata
	c.get_crate_data(krate).cdata.root.has_global_allocator

Same.

[petrochenkov]

I don't think this PR does the optimization correctly.
When incremental compilation is enabled, the cstore accesses should still be queries, not hooks, otherwise we get untracked accesses to data that may change.

[petrochenkov]

The current results are within noise, but let's re-measure the correct implementation just in case.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.