Fluent tidy improvements

[GuillaumeGomez]

Follow-up of #147345 and of #147191.

It uses fluent_syntax to parse fluent files (but not for blessing, not even sure how the current one works).

I also added an assert to ensure we never go to previous situation where the fluent files were actually not checked at all.

cc @Kivooeo
r? kobzol

[Kivooeo]

Looks great, nice that we can use builtin things to parse it

Have you test it locally?

[GuillaumeGomez]

A bit, it detects what it's supposed to.

[Kobzol]

This is great, thanks! Do you think we could also use the parser for sorting the records?

View changes since this review

[GuillaumeGomez]

This is great, thanks! Do you think we could also use the parser for sorting the records?

It's the part I'm unclear about. The current seems to only move the line where the message is defined, but I don't know if it moves its content too. And what happens about comments, etc etc.

I can look into it in a follow-up if you want?

[Kobzol]

Sure, it seems more complicated.

[GuillaumeGomez]

Applied suggestions.

[Kobzol]

Looks good, thanks!

@bors r+ rollup

[bors]

📌 Commit 831cdf3 has been approved by Kobzol

It is now in the queue for this repository.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[GuillaumeGomez]

Sorry, pushed another code to this branch. Fixed it.

[GuillaumeGomez]

@bors r=kobzol rollup

[bors]

📌 Commit 831cdf3 has been approved by kobzol

It is now in the queue for this repository.