-
Notifications
You must be signed in to change notification settings - Fork 13.8k
refactor: replace LLVMRustBuildMem{Cpy,Move,Set}
with plain LLVM functions
#147474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nctions The only difference between our wrappers and the plain LLVM functions is that our wrappers take an extra `volatile` argument. But we can easily just set the `volatile` flag on the LLVM IR instructions after creating them using `LLVMSetVolatile`.
rustbot has assigned @jdonszelmann. Use |
The job Click to see the possible cause of the failure (guessed by this bot)
|
r? compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLVMSetVolatile does not support volatile on intrinsics. It only works on the instruction-level volatile flag.
Ah okay, so this would need to get fixed in LLVM first |
☔ The latest upstream changes (presumably #147519) made this pull request unmergeable. Please resolve the merge conflicts. |
The only difference between our wrappers and the plain LLVM functions is that our wrappers take an extra
volatile
argument. But we can easily just set thevolatile
flag on the LLVM IR instructions after creating them usingLLVMSetVolatile
.Work towards #46437